Update AstAnalyzer to account for BigInt

Adding necessary test coverage as well

PiperOrigin-RevId: 325345721

Author: JohnLuck77

src/com/google/javascript/jscomp/AstAnalyzer.java

@@ -60,7 +60,8 @@ public class AstAnalyzer {
   // can also be called as constructors but lack side-effects.
   // TODO(johnlenz): consider adding an extern annotation for this.
   private static final ImmutableSet<String> BUILTIN_FUNCTIONS_WITHOUT_SIDEEFFECTS =
-      ImmutableSet.of("Object", "Array", "String", "Number", "Boolean", "RegExp", "Error");
+      ImmutableSet.of(
+          "Object", "Array", "String", "Number", "BigInt", "Boolean", "RegExp", "Error");
   private static final ImmutableSet<String> OBJECT_METHODS_WITHOUT_SIDEEFFECTS =
       ImmutableSet.of("toString", "valueOf");
   private static final ImmutableSet<String> REGEXP_METHODS = ImmutableSet.of("test", "exec");
@@ -357,6 +358,7 @@ && checkForStateChangeHelper(member.getFirstChild(), checkForNewObjects)) {
         // Any context that supports DEFAULT_VALUE is already an assignment. The possiblity of a
         // default doesn't itself create a side-effect. Therefore, we prefer to defer the decision.
       case NUMBER:
+      case BIGINT:
       case OR:
       case COALESCE:
       case THIS:

test/com/google/javascript/jscomp/AstAnalyzerTest.java

@@ -25,6 +25,7 @@
 import static com.google.javascript.rhino.Token.ASSIGN;
 import static com.google.javascript.rhino.Token.ASSIGN_ADD;
 import static com.google.javascript.rhino.Token.AWAIT;
+import static com.google.javascript.rhino.Token.BIGINT;
 import static com.google.javascript.rhino.Token.BITOR;
 import static com.google.javascript.rhino.Token.CALL;
 import static com.google.javascript.rhino.Token.CLASS;
@@ -257,6 +258,7 @@ public static Iterable<AnalysisCase> cases() {
           kase().js("/abc/gi").token(REGEXP).expect(true),
           kase().js("'a'").token(STRING).expect(false),
           kase().js("0").token(NUMBER).expect(false),
+          kase().js("1n").token(BIGINT).expect(false),
           kase().js("a + c").token(ADD).expect(false),
           kase().js("'c' + a[0]").token(ADD).expect(false),
           kase().js("a[0][1]").token(GETELEM).expect(false),
@@ -788,6 +790,35 @@ public void testCallSideEffects() {
     }
   }
 
+  @RunWith(Parameterized.class)
+  public static class BuiltInFunctionWithoutSideEffects {
+
+    @Parameter(0)
+    public String functionName;
+
+    @Parameters(name = "#{index} {0}")
+    public static final ImmutableList<Object[]> cases() {
+      return ImmutableList.copyOf(
+          new Object[][] {
+            {"Object"},
+            {"Array"},
+            {"String"},
+            {"Number"},
+            {"BigInt"},
+            {"Boolean"},
+            {"RegExp"},
+            {"Error"}
+          });
+    }
+
+    @Test
+    public void test() {
+      ParseHelper parseHelper = new ParseHelper();
+      Node func = parseHelper.parseFirst(CALL, SimpleFormat.format("%s(1);", functionName));
+      assertThat(parseHelper.getAstAnalyzer().functionCallHasSideEffects(func)).isFalse();
+    }
+  }
+
   @RunWith(JUnit4.class)
   public static class ConstructorCallHasSideEffects {
     @Test

test/com/google/javascript/jscomp/integration/AdvancedOptimizationsIntegrationTest.java

@@ -224,9 +224,7 @@ public void testBigIntStringConcatenation() {
     CompilationLevel.ADVANCED_OPTIMIZATIONS.setOptionsForCompilationLevel(options);
     options.setLanguage(LanguageMode.ECMASCRIPT_NEXT);
     externs = ImmutableList.of(new TestExternsBuilder().addBigInt().buildExternsFile("externs.js"));
-    // TODO(b/140132715): This test should expect "1nasdf", must update PeepholeFoldConstants
-    // for this to work as intended
-    test(options, "1n + 'asdf'", "1n + 'asdf'");
+    test(options, "1n + 'asdf'", "'1nasdf'");
   }
 
   @Test