Remove unused const step factory.

eval/eval/BUILD

@@ -176,21 +176,14 @@ cc_library(
 
 cc_library(
     name = "const_value_step",
-    srcs = [
-        "const_value_step.cc",
-    ],
     hdrs = [
         "const_value_step.h",
     ],
     deps = [
         ":compiler_constant_step",
         ":direct_expression_step",
         ":evaluator_core",
-        "//common:allocator",
-        "//common:constant",
         "//common:value",
-        "//internal:status_macros",
-        "//runtime/internal:convert_constant",
         "@com_google_absl//absl/status:statusor",
     ],
 )
@@ -610,36 +603,6 @@ cc_test(
     ],
 )
 
-cc_test(
-    name = "const_value_step_test",
-    size = "small",
-    srcs = [
-        "const_value_step_test.cc",
-    ],
-    deps = [
-        ":cel_expression_flat_impl",
-        ":const_value_step",
-        ":evaluator_core",
-        "//base:data",
-        "//common:constant",
-        "//common:expr",
-        "//eval/internal:errors",
-        "//eval/public:activation",
-        "//eval/public:cel_value",
-        "//eval/public/testing:matchers",
-        "//internal:status_macros",
-        "//internal:testing",
-        "//runtime:runtime_options",
-        "//runtime/internal:runtime_env",
-        "//runtime/internal:runtime_env_testing",
-        "@com_google_absl//absl/base:nullability",
-        "@com_google_absl//absl/status",
-        "@com_google_absl//absl/status:statusor",
-        "@com_google_absl//absl/time",
-        "@com_google_protobuf//:protobuf",
-    ],
-)
-
 cc_test(
     name = "container_access_step_test",
     size = "small",

eval/eval/const_value_step.h

@@ -3,29 +3,28 @@
 
 #include <cstdint>
 #include <memory>
+#include <utility>
 
 #include "absl/status/statusor.h"
-#include "common/allocator.h"
-#include "common/constant.h"
 #include "common/value.h"
+#include "eval/eval/compiler_constant_step.h"
 #include "eval/eval/direct_expression_step.h"
 #include "eval/eval/evaluator_core.h"
 
 namespace google::api::expr::runtime {
 
-std::unique_ptr<DirectExpressionStep> CreateConstValueDirectStep(
-    cel::Value value, int64_t expr_id = -1);
-
-// Factory method for Constant Value expression step.
-absl::StatusOr<std::unique_ptr<ExpressionStep>> CreateConstValueStep(
-    cel::Value value, int64_t expr_id, bool comes_from_ast = true);
+// Factory method for Constant AST node expression recursive step.
+inline std::unique_ptr<DirectExpressionStep> CreateConstValueDirectStep(
+    cel::Value value, int64_t id = -1) {
+  return std::make_unique<DirectCompilerConstantStep>(std::move(value), id);
+}
 
 // Factory method for Constant AST node expression step.
-// Copies the Constant Expr node to avoid lifecycle dependency on source
-// expression.
-absl::StatusOr<std::unique_ptr<ExpressionStep>> CreateConstValueStep(
-    const cel::Constant&, int64_t expr_id, cel::Allocator<> allocator,
-    bool comes_from_ast = true);
+inline absl::StatusOr<std::unique_ptr<ExpressionStep>> CreateConstValueStep(
+    cel::Value value, int64_t expr_id, bool comes_from_ast = true) {
+  return std::make_unique<CompilerConstantStep>(std::move(value), expr_id,
+                                                comes_from_ast);
+}
 
 }  // namespace google::api::expr::runtime