CL: Add check for 2d image creation from buffer

CL_INVALID_OPERATION must be returned when creating a 2d image from the
buffer if cl_khr_image2d_from_buffer is not supported.

Tests-Passing: OCLCTS.test_api consistency_2d_image_from_buffer
Bug: angleproject:384765581
Change-Id: I431188b9c1d1881cf755058a8b8ca5741d17652d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6102106
Commit-Queue: Gowtham Tammana <[email protected]>
Reviewed-by: Shahbaz Youssefi <[email protected]>
Reviewed-by: Geoff Lang <[email protected]>

Author: alexdean08

src/libANGLE/CLContext.h

@@ -113,6 +113,7 @@ class Context final : public _cl_context, public Object
     bool supportsImages() const;
     bool supportsIL() const;
     bool supportsBuiltInKernel(const std::string &name) const;
+    bool supportsImage2DFromBuffer() const;
 
     static void CL_CALLBACK ErrorCallback(const char *errinfo,
                                           const void *privateInfo,
@@ -180,6 +181,13 @@ inline bool Context::supportsImages() const
             }) != mDevices.cend());
 }
 
+inline bool Context::supportsImage2DFromBuffer() const
+{
+    return (std::find_if(mDevices.cbegin(), mDevices.cend(), [](const DevicePtr &ptr) {
+                return ptr->getInfo().khrImage2D_FromBuffer == true;
+            }) != mDevices.cend());
+}
+
 inline bool Context::supportsIL() const
 {
     return (std::find_if(mDevices.cbegin(), mDevices.cend(), [](const DevicePtr &ptr) {

src/libANGLE/validationCL.cpp

@@ -3086,6 +3086,15 @@ cl_int ValidateCreateImage(cl_context context,
         return CL_INVALID_OPERATION;
     }
 
+    // Returns CL_INVALID_OPERATION if no devices in context support creating a 2D image from a
+    // buffer.
+    const bool isImage2dFromBuffer =
+        image_desc->image_type == CL_MEM_OBJECT_IMAGE2D && image_desc->mem_object != NULL;
+    if (isImage2dFromBuffer && !ctx.supportsImage2DFromBuffer())
+    {
+        return CL_INVALID_OPERATION;
+    }
+
     // CL_INVALID_IMAGE_SIZE if image dimensions specified in image_desc exceed the maximum
     // image dimensions described in the Device Queries table for all devices in context.
     const DevicePtrs &devices = ctx.getDevices();