Define the mountpoint on the golang side. #1867
Open
+19
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ser-io
requested changes
Dec 4, 2025
| sudo mount --bind /dev/ /mnt/image/dev | ||
| sudo mount --bind /dev/pts /mnt/image/dev/pts | ||
| sudo mount --bind /run /mnt/image/run | ||
| MOUNTPONT=$1 |
Member
There was a problem hiding this comment.
Let's update other tools: create_gce_x86_64_image, create_gce_x86_64_fixed_kernel using this script as well.
Collaborator
Author
There was a problem hiding this comment.
These will require more wide refactors. I have however ensured that this mount script gets invoked correctly everywhere, though.
Then plumb that through to the script. This means that logic on the golang side owns the knowledge of the mountpoint, and doesn't need to assume that it knows what the mountpoint is from the shell script. For now, this is only done on the `gce_install_cuttlefish_packages` command.
3405691582
force-pushed
the
tools_refactor3
branch
from
0f1f105 to
201bc33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Then plumb that through to the script. This means that logic on the golang side owns the knowledge of the mountpoint, and doesn't need to assume that it knows what the mountpoint is from the shell script.