-
Notifications
You must be signed in to change notification settings - Fork 178
Retrieve operator & HO log via http api endpoint, without journald #1832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
frontend/debian/cuttlefish-orchestration.cuttlefish-host_orchestrator.init
Show resolved
Hide resolved
frontend/debian/cuttlefish-orchestration.cuttlefish-host_orchestrator.init
Outdated
Show resolved
Hide resolved
ser-io
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ser-io
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workaround LGTM.
However, do not merge the PR until it's actually needed. This new code is only needed for Docker, hence it should be merged after Docker is integrated.
SG. I'm currently trying GPU utilization on podman. Let's decide afterwards, by whether GPU utilization works or not. |
Providing HO/Operator via http is only needed by Tradefed and it's not a blocker. This mean, this PR would be needed when there are actual ATP tests using Docker, that would be the time to land this PR. |
QQ: This change works well even outside docker without regression, doesn't it? If so, I think merging it now wouldn't be harmful.. |
Providing HO/Operator via http is only needed by Tradefed, until there's an actual ATP test using the new Docker container solution this code is not needed hence landing this PR can wait till then. |
The circumstance is changed. Now I validated GPU can be utilized on podman instance. Also I validated a container image is available to be run on both docker and podman. Based on recent validations, I think the best option is deploying single container image which can be run on both, and keeping it stable via doing E2E test on both. We all know that there are some places to be able to use podman, not docker. On the other hand, Cloud Orchestrator via on-premise configuration is getting to have real use cases, but docker is the only integrated solution today. The problem starts from sharing container image from both. Podman can start init process for itself, but docker can't. Even if it's possible, not recommended. But without starting init process, BTW, I want to raise a concern for using |
When will "soon" be? This is not clear, hence the position to wait and then merge later when needed. The moment there's an actual use case for this change, this PR can definitely land. |
This allows to retrieve operator & Host Orchestrator log via HTTP/HTTPS API endpoint through nginx, but it doesn't rely on systemd-journal-gatewayd.
Context: b/385123612
Verified on podman:
GET /_journal/entries?_SYSTEMD_UNIT=cuttlefish-operator.serviceGET /_journal/entries?_SYSTEMD_UNIT=cuttlefish-host_orchestrator.serviceGET /hostlogs/cuttlefish-operator.serviceGET /hostlogs/cuttlefish-host_orchestrator.servicecat /run/cuttlefish/operator.logcat /run/cuttelfish/host_orchestrator.logsudo systemctl status cuttlefish-operatorsudo systemctl status cuttlefish-host_orchestratorVerified on docker:
GET /hostlogs/cuttlefish-operator.serviceGET /hostlogs/cuttlefish-host_orchestrator.servicecat /run/cuttlefish/operator.logcat /run/cuttelfish/host_orchestrator.log