Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry tracing manual instrumentation support #568

Open
filipecosta90 opened this issue Jul 29, 2021 · 3 comments
Open

OpenTelemetry tracing manual instrumentation support #568

filipecosta90 opened this issue Jul 29, 2021 · 3 comments

Comments

@filipecosta90
Copy link
Contributor

filipecosta90 commented Jul 29, 2021

In the same way as seen on the OpenTelemetry instrumentation forgo-redis it would be extremely beneficial to create a similar package for redigo. Not only we can track the overhead of the client code, but we can also precisely trace errors/latency spikes/timeouts/etc...

Some further info:

Important Note: Semantic conventions to follow while preparing a package for manual instrumentation.

While this is not mandatory, we should aim for standardization across clients/languages/DBs. Here's the spec on DB semantic conventions:

https://github.com/open-telemetry/semantic-conventions/blob/main/docs/database/redis.md

PS: will gladly contribute to this matter.

@stevenh
Copy link
Collaborator

stevenh commented Aug 20, 2023

This should be totally possible within an external package.

@stevenh
Copy link
Collaborator

stevenh commented Jan 28, 2024

Related to #642

@stevenh
Copy link
Collaborator

stevenh commented Jan 28, 2024

This is related to a similar conversation about adding slog support, which has me thinking about a #656 (comment) which should consider this use case as well.

Would like to hear peoples thoughts on that as an approach?

@stevenh stevenh mentioned this issue Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants