Version formatting mismatch between release assets vs container images

[alebcay]

When using binaries downloaded from release assets (built using goreleaser), the version printed in golangci-lint --version does not contain the leading v prefix. This is because {{.Version}} will have its leading v stripped off by goreleaser.

golangci-lint/.goreleaser.yml

Line 44 in cd0d344

ldflags: -s -w -X main.version={{.Version}} -X main.commit={{.ShortCommit}} -X main.date={{.Date}}

However, the version printed in golangci-lint --version when using one of the official container images does contain the leading v prefix. This is because the VERSION is derived from tag name, without leading v stripped off.

golangci-lint/.github/workflows/tag.yml

Line 92 in cd0d344

VERSION=${{ steps.prepare.outputs.tag_name }}

This is hardly a bug (hence opening this as discussion rather than issue) but I figure it might be nice if these matched regardless of where a user obtains golangci-lint.

Happy to open a PR to help fix but would need guidance on which is preferred - keep the v prefix or exclude it.

[ldez]

Hello,

good catch.

The easier fix is to add the v but we can say that the current format (without the v) for binaries is the "real expected format" because binaries are the "main" resources.

So I think the "right" solution is to strip the v for the Docker image.