embedding interface element requires go1.18 or later (-lang was set to go1.16; check go.mod)

[kutlueren]

Welcome

• Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
• Yes, I've searched similar issues on GitHub and didn't find any.
• Yes, I've included all information below (version, config, etc).
• Yes, I've tried with the standalone linter if available. (https://golangci-lint.run/usage/linters/)

Description of the problem

I have a test pipeline where I execute unit tests before merging the pr and there I also download and execute golanci-lint binary to check the code. For some reason, v1.49.0 version is giving the following error. v1.47.2 however seems to be working.

Error: ../../../go/pkg/mod/golang.org/x/[email protected]/constraints/constraints.go:13:2: embedding interface element ~int|~int8|~int16|~int32|~int64 requires go1.18 or later (-lang was set to go1.16; check go.mod)
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/constraints/constraints.go:20:2: embedding interface element ~uint|~uint8|~uint16|~uint32|~uint64|~uintptr requires go1.18 or later (-lang was set to go1.16; check go.mod)
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/constraints/constraints.go:27:2: embedding interface element Signed|Unsigned requires go1.18 or later (-lang was set to go1.16; check go.mod)
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/constraints/constraints.go:34:2: embedding interface element ~float32|~float64 requires go1.18 or later (-lang was set to go1.16; check go.mod)
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/constraints/constraints.go:41:2: embedding interface element ~complex64|~complex128 requires go1.18 or later (-lang was set to go1.16; check go.mod)
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/constraints/constraints.go:49:2: embedding interface element Integer|Float|~string requires go1.18 or later (-lang was set to go1.16; check go.mod)
make: *** [Makefile:33: bin/golangci-lint] Error 2
Error: Process completed with exit code 2.

I have checked the library which presumably causing the error also has the go version 1.18 set in the mod file. Can anyone recommend any solutions? I have reverted the version to 1.47.2 so it is okay at the moment for the pipeline.

Version of golangci-lint

$ golangci-lint --version
# 1.49.0

Configuration file

$ cat .golangci.yml
# paste output here

Go environment

$ go version && go env
# 1.19

Verbose output of running

$ golangci-lint cache clean
$ golangci-lint run -v
# paste output here

Code example or link to a public repository

Makefile:

GOLANGCILINT = bin/golangci-lint run
$(GOLANGCILINT): export GOBIN := $(PWD)/bin
$(GOLANGCILINT): go.mod
	$(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.47.2
	
.PHONY: test
test: build-all $(GOLANGCILINT) $(STATICCHECK)
	$(GO) fmt ./...
	$(GO) vet ./...
	$(GO) test -cover -race ./...
	$(GOLANGCILINT) ./...
	$(STATICCHECK) ./...

Here is the pipeline yaml

on: push
jobs:
  test:
    runs-on: ubuntu-20.04
    steps:
      - uses: actions/checkout@v2
      - uses: actions/setup-go@v2
        with:
          go-version: '1.19.0'
      - run: make test fail-dirty
        env:
          GOFLAGS: -mod=readonly

[ldez]

Hello,

can you fill required sections of the issue description?

I also download and execute golangci-lint binary

From your logs, I think you do not download it but built it by using go install or the tools pattern.

I think you are using go1.16 on your CI, so:

• update the installed version of Go to >=go1.18
• use our binaries

[ldez]

It's not specific to golangci-lint.

golang.org/x/exp is required by golangci-lint because of github.com/GaijinEntertainment/go-exhaustruct which has been introduced recently.

If you try the following command you will see the exact same problem:

$ go install -mod=readonly github.com/GaijinEntertainment/go-exhaustruct/v2/cmd/[email protected]
go: downloading github.com/GaijinEntertainment/go-exhaustruct/v2 v2.3.0
go: downloading golang.org/x/tools v0.1.12
go: downloading golang.org/x/exp v0.0.0-20220722155223-a9213eeb770e
go: downloading golang.org/x/sys v0.0.0-20220722155257-8c9f86f7a55f
go: downloading golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4
# golang.org/x/exp/constraints
pkg/mod/golang.org/x/[email protected]/constraints/constraints.go:13:2: embedding interface element ~int|~int8|~int16|~int32|~int64 requires go1.18 or later (-lang was set to go1.16; check go.mod)
pkg/mod/golang.org/x/[email protected]/constraints/constraints.go:20:2: embedding interface element ~uint|~uint8|~uint16|~uint32|~uint64|~uintptr requires go1.18 or later (-lang was set to go1.16; check go.mod)
pkg/mod/golang.org/x/[email protected]/constraints/constraints.go:27:2: embedding interface element Signed|Unsigned requires go1.18 or later (-lang was set to go1.16; check go.mod)
pkg/mod/golang.org/x/[email protected]/constraints/constraints.go:34:2: embedding interface element ~float32|~float64 requires go1.18 or later (-lang was set to go1.16; check go.mod)
pkg/mod/golang.org/x/[email protected]/constraints/constraints.go:41:2: embedding interface element ~complex64|~complex128 requires go1.18 or later (-lang was set to go1.16; check go.mod)
pkg/mod/golang.org/x/[email protected]/constraints/constraints.go:49:2: embedding interface element Integer|Float|~string requires go1.18 or later (-lang was set to go1.16; check go.mod)

I suspect there's something that could be done about it within golangci-lint to avoid the issue.

Nothing can be done inside golangci-lint because it's related to the management of transitive dependencies and remote download.

FYI if you try to do a local go install ./cmd/golangci-lint there is no issue.

I will report the problem to the Go team.

[kutlueren]

Thanks a lot @ldez and @bhcleek

[ldez]

golang/go#54908

[ldez]

As a workaround, I think can use go install -mod=mod

[kutlueren]

Seems to be working, thanks a lot