Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

may you add default replicas ? #156

Open
ZBIGBEAR opened this issue Jun 19, 2022 · 0 comments
Open

may you add default replicas ? #156

ZBIGBEAR opened this issue Jun 19, 2022 · 0 comments

Comments

@ZBIGBEAR
Copy link

1.add default replicas
groupcache/consistenthash.go: line 34.
replicas must has a default value. if replicas <=0, then it will do nothing when call func (m *Map) Add(keys ...string)

and i suggest the default replicas value is 23

2.add sync.Mutex. when call Add and Get,we can lock the kes and hashMap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant