Skip to content

Commit b76863e

Browse files
committed
x86asm: include size suffix on popcnt instruction
Update golang/go#48584 Change-Id: I2c770aaf88e15f8987dc8f1d974127b02b220777 Reviewed-on: https://go-review.googlesource.com/c/arch/+/351889 Trust: Keith Randall <[email protected]> Run-TryBot: Keith Randall <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Cherry Mui <[email protected]>
1 parent 6544aa4 commit b76863e

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

x86/x86asm/plan9x.go

+1
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ var plan9Suffix = [maxOp + 1]bool{
204204
OUT: true,
205205
POP: true,
206206
POPA: true,
207+
POPCNT: true,
207208
PUSH: true,
208209
PUSHA: true,
209210
RCL: true,

x86/x86asm/testdata/decode.txt

+5-5
Original file line numberDiff line numberDiff line change
@@ -6518,10 +6518,10 @@ f30faec8|11223344556677885f5f5f5f 64 gnu rdgsbase %eax
65186518
f30faec8|11223344556677885f5f5f5f 64 intel rdgsbase eax
65196519
f30faec8|11223344556677885f5f5f5f 64 plan9 RDGSBASE AX
65206520
f30fb811|223344556677885f5f5f5f5f 32 intel popcnt edx, dword ptr [ecx]
6521-
f30fb811|223344556677885f5f5f5f5f 32 plan9 POPCNT 0(CX), DX
6521+
f30fb811|223344556677885f5f5f5f5f 32 plan9 POPCNTL 0(CX), DX
65226522
f30fb811|223344556677885f5f5f5f5f 64 gnu popcnt (%rcx),%edx
65236523
f30fb811|223344556677885f5f5f5f5f 64 intel popcnt edx, dword ptr [rcx]
6524-
f30fb811|223344556677885f5f5f5f5f 64 plan9 POPCNT 0(CX), DX
6524+
f30fb811|223344556677885f5f5f5f5f 64 plan9 POPCNTL 0(CX), DX
65256525
f30fbc11|223344556677885f5f5f5f5f 32 intel tzcnt edx, dword ptr [ecx]
65266526
f30fbc11|223344556677885f5f5f5f5f 32 plan9 TZCNT 0(CX), DX
65276527
f30fbc11|223344556677885f5f5f5f5f 64 gnu tzcnt (%rcx),%edx
@@ -6565,18 +6565,18 @@ f3480faec8|11223344556677885f5f5f 64 intel rdgsbase rax
65656565
f3480faec8|11223344556677885f5f5f 64 plan9 RDGSBASE AX
65666566
f3480fb811|223344556677885f5f5f5f 64 gnu popcnt (%rcx),%rdx
65676567
f3480fb811|223344556677885f5f5f5f 64 intel popcnt rdx, qword ptr [rcx]
6568-
f3480fb811|223344556677885f5f5f5f 64 plan9 POPCNT 0(CX), DX
6568+
f3480fb811|223344556677885f5f5f5f 64 plan9 POPCNTQ 0(CX), DX
65696569
f3480fbc11|223344556677885f5f5f5f 64 gnu tzcnt (%rcx),%rdx
65706570
f3480fbc11|223344556677885f5f5f5f 64 intel tzcnt rdx, qword ptr [rcx]
65716571
f3480fbc11|223344556677885f5f5f5f 64 plan9 TZCNT 0(CX), DX
65726572
f3480fbd11|223344556677885f5f5f5f 64 gnu lzcnt (%rcx),%rdx
65736573
f3480fbd11|223344556677885f5f5f5f 64 intel lzcnt rdx, qword ptr [rcx]
65746574
f3480fbd11|223344556677885f5f5f5f 64 plan9 LZCNT 0(CX), DX
65756575
f3660fb811|223344556677885f5f5f5f 32 intel popcnt dx, word ptr [ecx]
6576-
f3660fb811|223344556677885f5f5f5f 32 plan9 POPCNT 0(CX), DX
6576+
f3660fb811|223344556677885f5f5f5f 32 plan9 POPCNTW 0(CX), DX
65776577
f3660fb811|223344556677885f5f5f5f 64 gnu popcnt (%rcx),%dx
65786578
f3660fb811|223344556677885f5f5f5f 64 intel popcnt dx, word ptr [rcx]
6579-
f3660fb811|223344556677885f5f5f5f 64 plan9 POPCNT 0(CX), DX
6579+
f3660fb811|223344556677885f5f5f5f 64 plan9 POPCNTW 0(CX), DX
65806580
f3660fbc11|223344556677885f5f5f5f 32 intel tzcnt dx, word ptr [ecx]
65816581
f3660fbc11|223344556677885f5f5f5f 32 plan9 TZCNT 0(CX), DX
65826582
f3660fbc11|223344556677885f5f5f5f 64 gnu tzcnt (%rcx),%dx

0 commit comments

Comments
 (0)