Skip to content

Commit ebbb306

Browse files
authored
Remove gofumports (#101)
1 parent fd02a40 commit ebbb306

File tree

3 files changed

+6
-73
lines changed

3 files changed

+6
-73
lines changed

Makefile

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
.PHONY: dev
44
dev: ## dev build
5-
dev: clean install generate build fmt lint test mod-tidy build-snapshot
5+
dev: clean generate build fmt lint test mod-tidy build-snapshot
66

77
.PHONY: ci
88
ci: ## CI build
@@ -14,13 +14,6 @@ clean: ## remove files created during build
1414
rm -rf dist
1515
rm -f coverage.*
1616

17-
.PHONY: install
18-
install: ## install build tools
19-
$(call print-target)
20-
cd tools && go install mvdan.cc/gofumpt/gofumports
21-
cd tools && go install github.com/golangci/golangci-lint/cmd/golangci-lint
22-
cd tools && go install github.com/goreleaser/goreleaser
23-
2417
.PHONY: generate
2518
generate: ## go generate
2619
$(call print-target)
@@ -32,13 +25,14 @@ build: ## go build
3225
go build -o /dev/null ./...
3326

3427
.PHONY: fmt
35-
fmt: ## gofumports
28+
fmt: ## go fmt
3629
$(call print-target)
37-
gofumports -l -w -local github.com/golang-templates/seed . || true
30+
go fmt ./...
3831

3932
.PHONY: lint
4033
lint: ## golangci-lint
4134
$(call print-target)
35+
cd tools && go install github.com/golangci/golangci-lint/cmd/golangci-lint
4236
golangci-lint run
4337

4438
.PHONY: test
@@ -56,6 +50,7 @@ mod-tidy: ## go mod tidy
5650
.PHONY: build-snapshot
5751
build-snapshot: ## goreleaser --snapshot --skip-publish --rm-dist
5852
$(call print-target)
53+
cd tools && go install github.com/goreleaser/goreleaser
5954
goreleaser --snapshot --skip-publish --rm-dist
6055

6156
.PHONY: diff

cmd/seed/main_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,5 @@ import (
99
func Test_greet(t *testing.T) {
1010
got := greet()
1111

12-
want := "Hi!"
13-
assert.Equal(t, want, got, "should properly greet")
12+
assert.Equal(t, "Hi!", got, "should properly greet")
1413
}

0 commit comments

Comments
 (0)