Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed redirection logic #419

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

PaarthAgarwal
Copy link
Contributor

Signed-off-by: PaarthAgarwal [email protected]
An attempt to fix #334.

Signed-off-by: PaarthAgarwal <[email protected]>
Signed-off-by: PaarthAgarwal <[email protected]>
Signed-off-by: PaarthAgarwal <[email protected]>
Signed-off-by: PaarthAgarwal <[email protected]>
@PaarthAgarwal PaarthAgarwal marked this pull request as ready for review February 13, 2023 12:26
@PaarthAgarwal PaarthAgarwal requested review from a team as code owners February 13, 2023 12:26
@PaarthAgarwal
Copy link
Contributor Author

Apologies for so many commits. I wasn't able to test it on the local server so had to rely on netlify deploy preview. Works fine now

@OrlinVasilev
Copy link
Member

it's not ok for some reason
image

@PaarthAgarwal
Copy link
Contributor Author

Didn't think about this case!

Signed-off-by: PaarthAgarwal <[email protected]>
Signed-off-by: PaarthAgarwal <[email protected]>
Signed-off-by: PaarthAgarwal <[email protected]>
@PaarthAgarwal PaarthAgarwal marked this pull request as draft February 13, 2023 14:26
Signed-off-by: PaarthAgarwal <[email protected]>
Signed-off-by: PaarthAgarwal <[email protected]>
Signed-off-by: PaarthAgarwal <[email protected]>
Signed-off-by: PaarthAgarwal <[email protected]>
@PaarthAgarwal PaarthAgarwal marked this pull request as ready for review February 13, 2023 17:53
@PaarthAgarwal
Copy link
Contributor Author

PaarthAgarwal commented Feb 13, 2023

@OrlinVasilev this is ready for another round of review. Squash the commits into one while merging or I'll be happy to make a fresh PR with a single commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the version number in the URL
2 participants