feat: modified registy update command #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Althaf66 <[email protected]>
bupd
suggested changes
May 29, 2024
| if err != nil { | ||
| log.Errorf("failed to update registry: %v", err) | ||
| } | ||
| }, | ||
| } | ||
|
|
||
| flags := cmd.Flags() |
There was a problem hiding this comment.
Thanks for your contribution! Could you please add back the below flags? They're crucial for automation and scripting processes, and their absence could potentially disrupt CI/CD pipelines.
Thanks.
There was a problem hiding this comment.
Yes. I will add those flags.
|
heads up: merge conflicts |
|
@Althaf66 merge conflicts. otherwise, LGTM 🙌 |
Signed-off-by: ALTHAF <[email protected]>
Signed-off-by: ALTHAF <[email protected]>
|
update with empty id and secret shoould work |
Signed-off-by: ALTHAF <[email protected]>
Signed-off-by: ALTHAF <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #87
Registry values where shown in the input field so, user have easier to update the values in the registry. This fuctionality present in the Web UI