Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Password Prompt to Login #108

Open
AquaBearCo opened this issue Jun 5, 2024 · 7 comments
Open

Add Password Prompt to Login #108

AquaBearCo opened this issue Jun 5, 2024 · 7 comments

Comments

@AquaBearCo
Copy link

Would be good if Login had the ability to prompt for a hidden password for security.

example ideas:
harbor login demo.goharbor.io -u admin
Password Prompt: **********

harbor login demo.goharbor.io -u admin --passwordprompt
Password Prompt: **********

@bupd
Copy link
Collaborator

bupd commented Jun 5, 2024

Hi @AquaBearCo,

Thank you for your suggestion! There is already an issue for handling password login #10 . Fixing that issue will address your request for a hidden password prompt during login.
Thanks.

@HiRoaR2002
Copy link

@bupd I tried logging in but got the message this message:-
Screenshot 2024-06-18 164158

@bupd
Copy link
Collaborator

bupd commented Jun 18, 2024

Yes it's a known issue. And it will be fixed when adding the PR.

it's coming because you gave the server as demo.goharbor.io instead of https://demo.goharbor.io
try with https it should work.

Thanks.

@HiRoaR2002
Copy link

Thanks.
It Helped.

@HiRoaR2002
Copy link

HiRoaR2002 commented Jun 18, 2024

I have successfully created a password prompt using "term" package of go, which can invoked using --passprompt command
like this:-
Screenshot 2024-06-18 205912
I have also added a "Logged In Successfully" messege as before there was no notification.

@HiRoaR2002
Copy link

@AquaBearCo please assign the issue to me so that i can push the changes in new branch

@bupd
Copy link
Collaborator

bupd commented Jul 31, 2024

Consider closing this issue as Harbor-CLI now by default masks password. @AquaBearCo
// @Vad1mo

masked Input lgin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants