Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor controllers #40

Open
Buccaneer opened this issue Aug 5, 2016 · 1 comment
Open

Refactor controllers #40

Buccaneer opened this issue Aug 5, 2016 · 1 comment

Comments

@Buccaneer
Copy link
Member

Still plenty of controllers with too much logic that could be separated out.
Buccaneer pushed a commit that referenced this issue Aug 5, 2016
#40 move location settings out of controller, into a separate service
abd6f07
Buccaneer pushed a commit that referenced this issue Aug 5, 2016
#40 Add docs to tracker controller
03467ab
Buccaneer pushed a commit that referenced this issue Aug 5, 2016
#40 Fix slight oversight
bf5ff15
Buccaneer pushed a commit that referenced this issue Aug 8, 2016
#40 Separate service for popup,
6ad07df 
move #toggleTracking() logic to #startTracking() and #stopTracking(),
rewrite #startTracking() promise chain
@Buccaneer
Copy link
Member Author

Note to self: make services like LocationUtils and TimeUtils to gather (duplicate) related functions that are currently spread in controllers and elsewhere.

Buccaneer pushed a commit that referenced this issue Aug 16, 2016
#40 Refactor group controller
4a098a2
@Buccaneer Buccaneer mentioned this issue Aug 17, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Buccaneer