Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhysicsDirectSpaceState2D.get_rest_info claims not to use query motion but it does #10609

Open
psychicteeth opened this issue Feb 3, 2025 · 2 comments
Labels
area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository good first issue topic:physics

Comments

@psychicteeth
Copy link

Your Godot version:
4.3

Issue description:
get_rest_info is described int he documentation as not taking into account the motion parameter of the input query. However, it does, and does so apparently by design if I am reading this thread correctly.

The docs should not say the function doesn't take motion into account when it does.

URL to the documentation page:
https://docs.godotengine.org/en/stable/classes/class_physicsdirectspacestate2d.html#class-physicsdirectspacestate2d-method-get-rest-info

If you know how to fix the issue you are reporting please
consider opening a pull request. We provide a tutorial on
using git here: https://docs.godotengine.org/en/stable/community/contributing/pr_workflow.html,
writing documentation at https://docs.godotengine.org/en/stable/community/contributing/docs_writing_guidelines.html
and contributing to the class reference here: https://docs.godotengine.org/en/stable/community/contributing/updating_the_class_reference.html

@AThousandShips
Copy link
Member

Did you confirm that this is the case in 4.3? The thread in question is 5 years old, and a lot have changed since then

@psychicteeth
Copy link
Author

Yes, the reason I posted was because I was getting data back from this function that shouldn't have been there (but would have been if the motion I sent in the query were taken into account). When I set the motion to 0, the function returned nothing as expected.

@AThousandShips AThousandShips added good first issue area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository topic:physics labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository good first issue topic:physics
Projects
None yet
Development

No branches or pull requests

2 participants