Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] .Net Core Support #448

Open
HurricanKai opened this issue Sep 8, 2018 · 7 comments
Open

[Discussion] .Net Core Support #448

HurricanKai opened this issue Sep 8, 2018 · 7 comments

Comments

@HurricanKai
Copy link

This is not an issue, so i dont use the template, but simply enough, to make it easier to run this on Linux, i woud suggest updating to .Net Core. Ill create a Fork later today doing this.

I simply created this as a Reference for a possible future Pull Request & As Discussion place

@HurricanKai
Copy link
Author

HurricanKai commented Sep 8, 2018

This Project in general looks fairly Abandoned, how is its status?
I mean i see that there are updates to the latest KSP Versions, but on bugs?

@Xinayder
Copy link
Collaborator

Xinayder commented Sep 8, 2018

The main issue with supporting .NET Core is client-server incompatibility. We run .NET 3.5 as it was the version supported by Unity a few versions ago. I'm not sure if it changed, but we can look at it.

@HurricanKai
Copy link
Author

in 2018.3 unity will officially change all defaults to .Net 4.0
shortly after 3.5 will be deprecated!
To my knowledge the common stuff coud be done in .Net Standart and then Server in .Net Core and the Client in .Net 4 / 3.5? (i dont think this woud be much more work then just editing some settings, common to .Net Standart woud prob. be the biggest issue?)

@Xinayder
Copy link
Collaborator

Xinayder commented Sep 10, 2018

I'm not really sure, but I don't think it would be possible. .NET Core/Standard would present some incompatibilities between Common and Server/Client. We need to ensure they're both compatible with each other. Also, porting Common to .NET Core wouldn't have any difference.

@HurricanKai
Copy link
Author

but Porting Common to .Net Standart woud make it compatible with both .Net Core and .Net Framework?
at least if i remember this right?
What do you mean with incompatibilities if im not getting you here?

@joshudson
Copy link

The compatibility differences are likely to be so low for the code you share that it's almost certainly a few lines of #if and #else and you're done.

@tgxn
Copy link

tgxn commented Jul 7, 2021

This change would also allow the server to run in docker image mcr.microsoft.com/dotnet/sdk:5.0-alpine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants