fix: windows support for path loading #71
Conversation
fredbi
force-pushed
the
fix/windows-invalid-url
branch
from
cdba2d9 to
d1d6372
Compare
|
need to run an integration test with go-swagger's test suite |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 85.59% 86.38% +0.79%
==========================================
Files 13 13
Lines 1569 1587 +18
==========================================
+ Hits 1343 1371 +28
+ Misses 193 183 -10
Partials 33 33 ☔ View full report in Codecov by Sentry. |
fredbi
force-pushed
the
fix/windows-invalid-url
branch
from
29362e3 to
86392de
Compare
On windows, there are quite a few specifics when it comes to resolving a local file. This complexity stemmed from the desire to support common, albeit invalid URI constructs for windows. Overall, the original sin of this function has been to ignore the host part of an URI, but now we can't really break this behavior. * fixes go-openapi#72 * refactored the local path pre-processing, so the windows-specifics appear more clearly * fixed a few inconsistencies on windows file URIs and guarded against a panic * test: refactored tests for the local file strategy, now table-driven and more systematic * doc: added detailed documentation to LoadStrategy() * ci: re-enacted tests on windows * ci: temporarily muted past linting issues: relinting is deferred to another PR Signed-off-by: Frederic BIDON <[email protected]>
fredbi
force-pushed
the
fix/windows-invalid-url
branch
from
86392de to
6c3422a
Compare
Signed-off-by: Frederic BIDON <[email protected]>
fredbi
changed the title
|
Fixing this, I now realize the original sin of the LoadStrategy() func when dealing with file:// URI... Well now we have to keep it this way, and make sure that this also works on windows. In hindsight, I have some regrets not to impose earlier a strict approach to file URIs... At least it works, runs tests, doesn't break go-swagger CI... |
No description provided.