Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extra param to bytesToString() #49

Open
unional opened this issue Apr 19, 2020 · 4 comments
Open

extra param to bytesToString() #49

unional opened this issue Apr 19, 2020 · 4 comments

Comments

@unional
Copy link

unional commented Apr 19, 2020

At https://github.com/go-macaroon/js-macaroon/blob/master/macaroon.js#L1015

Maybe you mean locationStr: bytesToString(v2JSONField(caveat, 'l', false)),?

I'm discover this while I try to add TypeScript definition to this library (actually I think converting to TypeScript is easier).

Are you open to accept PR for the type definition or convert to TypeScript?
@fabricematrat
Copy link
Contributor

Sure that's seems a good idea

@hatched hatched mentioned this issue Apr 21, 2020
Open
@hatched
Copy link
Collaborator

hatched commented Apr 21, 2020

I've created an issue to hold the discussion around converting this library to TS: #53

@hatched
Copy link
Collaborator

hatched commented Apr 21, 2020

And good catch with that bug, thanks!

@unional
Copy link
Author

unional commented Apr 21, 2020

And good catch with that bug, thanks!

Thanks TypeScript for that one. ;)

@hatched hatched removed their assignment Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hatched @fabricematrat @unional