Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting package #79

Open
qaisjp opened this issue Jun 12, 2020 · 3 comments
Open

Formatting package #79

qaisjp opened this issue Jun 12, 2020 · 3 comments

Comments

@qaisjp
Copy link

qaisjp commented Jun 12, 2020

Hi,

I've got a tiny package here https://github.com/qaisjp/go-discord-irc/tree/master/irc/format which deals with irc text formatting.

The code is essentially ported from the following Node packages:

I'm currently fleshing it out a bit more to abide by the @DanielOaks's IRC formatting living specification and to clean it up a little bit / add tests.

I have not been able to find another package that provides the same functionality, so when I'm done, would you be open to me submitting a pull request to move that content into this repo or under the go-irc org?

p.s. I welcome all feedback on that package / will of course be happy to make any changes required for inclusion in this org.

@belak
Copy link
Member

belak commented Jun 12, 2020

Oh interesting! I've actually been looking for something like this. I'm mid-way through a bit of a re-write (moving Client out to an ircx package for extensions...), so this might work well as a sub-package of that. You can see the status of v4 and ircx in #78.

@qaisjp
Copy link
Author

qaisjp commented Jun 12, 2020

I've given that issue a little 👍 -- moving the client into ircx sounds great to me!

so this might work well as a sub-package of that

Interesting, so you'd prefer a PR to be sent to ircx instead? I suppose that makes sense, since IRC colors aren't formally part of any IRC specifications.

@belak
Copy link
Member

belak commented Jun 16, 2020

Yep, ircx would be best. Thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants