Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SASL auth #57

Open
belak opened this issue Oct 13, 2017 · 6 comments
Open

Handle SASL auth #57

belak opened this issue Oct 13, 2017 · 6 comments

Comments

@belak
Copy link
Member

belak commented Oct 13, 2017

Docs

https://ircv3.net/specs/extensions/sasl-3.1.html
https://ircv3.net/specs/extensions/sasl-3.2.html

Current Issues (And Possible Solutions)

There's no way to hook into the registration process. The way we handle CAP negotiation should be made more generic (hopefully so there's an extensible way to ensure something happens before registration), we should add a method of handling SASL auth before registration is done, and we should possibly expose the pre-registration system to the user.

@terinjokes
Copy link

@belak Do you have a recommended plan, if someone were to implement this? I'm no expert in SASL, and certainly not SASL in the context of IRC, but it doesn't seem like the CAP implementation here is flexible enough to support it entirely as a user.

@belak
Copy link
Member Author

belak commented Apr 9, 2018

As far as I'm aware (it's been a while since I've looked at implementing this since I haven't needed it) it's not the CAP implementation as much as it is that there's no current way to specify that something needs to be handled before registration is complete. I've updated the original comment with links to docs and some suggestions.

@terinjokes
Copy link

@belak I think we're in agreement, just stating it more-or-less differently.

@danopia
Copy link
Contributor

danopia commented Jul 4, 2019

I see you mentioned extending the CAP API to support arbitrary CAPs that need to be further discussed at registration time -- you'd prefer that over a change to specifically slot in a SASL credential?

@danopia danopia mentioned this issue May 7, 2020
@lavagetto
Copy link

@belak I would be interested in helping add SASL support to the library, as I want to convert my bots to use a base library that understands ircv3. Would you accept a patch adding specifically just SASL support or do you have other plans?

Happy to help move that forward either way.

@belak
Copy link
Member Author

belak commented Aug 15, 2022

Yes! I would be happy to accept a patch! Ideally it would involve an improvement to CAP support, but SASL seems important enough that I'd be willing to accept it as a stand-alone change.

I actually forgot about this, but I'll aim to get the develop branch merged back to master some time in the next week...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants