Fix GLsync definition #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though GLsync is defined as an opaque struct pointer, some drivers use non-pointer values for GLsync, which is incompatible with Go pointer semantics. As a workaround we redefine GLsync to be a pointer-width numeric value.
|
@errcw, sorry, I won't be able to review because of https://twitter.com/shurcool/status/871528913108971520. Maybe ask @dominikh? |
dmitshur
reviewed
Jun 20, 2017
type.go
Outdated
| @@ -106,7 +106,9 @@ func (t Type) GoType() string { | |||
| // an integer type. | |||
| return t.pointers() + "uintptr" | |||
| case "GLsync": | |||
| return t.pointers() + "unsafe.Pointer" | |||
| // GLsync is treated as an opaque, pointer-width type. Additional special | |||
| // case handling is required for the corresponding typedef, see below. | |||
There was a problem hiding this comment.
It's not very clear to me what "below" refers to. Do you mean CTypedef? Then it'd be better to say "see CTypedef."
|
As far as code goes, I've posted one minor comment above, otherwise LGTM. In terms of functionality, this PR is meant to resolve #71, is that so? If so, it should be verified/tested by those who can reproduce #71. I'm not spotting any problems, but I can't say I have a full understanding of the problem details. |
|
@errcw What's the status of this PR? |
|
Pending verification from dominikh@ in go-gl/gl#71 that this PR resolves the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though GLsync is defined as an opaque struct pointer, some drivers
use non-pointer values for GLsync, which is incompatible with Go pointer
semantics. As a workaround we redefine GLsync to be a pointer-width
numeric value.