Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download KHR/khrplatform.h #115

Merged
merged 5 commits into from
Apr 26, 2021
Merged

Download KHR/khrplatform.h #115

merged 5 commits into from
Apr 26, 2021

Conversation

dertseha
Copy link
Contributor

This PR extends glow in the following ways:

Download of KHR/khrplatform.h
As identified in a go-gl/gl comment , newest API specs all require the presence of KHR/khrplatform.h. This file is not always available, as it is (historically) part of the EGL package. While Linux systems could install the corresponding library, MS Windows does not have an easy solution.

This PR extends glow to also include the file from the repository, and include it in all generated packages, making them self-sustained.

Module-aware compatibility
In case both go-gl/glow and go-gl/gl (or any other target) are used outside GOPATH, resolution of package github.com/go-gl/glow does not work.
This PR changes the default behaviour of an immediate termination to a fallback of resolving the current working directory.
The corresponding adaption of specifying the necessary paths in the generation code of go-gl/gl will be provided in a tandem PR to this one.

Update of all spec files
The specification files have all been freshly updated. (Fresh execution of download command)

@errcw
Copy link
Member

errcw commented Apr 26, 2021

Looks great, thanks!

@errcw errcw merged commit 6e7fcbc into go-gl:master Apr 26, 2021
@dertseha dertseha deleted the feature/download-khrplatform branch April 30, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants