Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider changing GetCocoaWindow et al. signatures to return unsafe.Pointer rather than uintptr. #230

Closed
dmitshur opened this issue Oct 22, 2018 · 2 comments
Closed

Consider changing GetCocoaWindow et al. signatures to return unsafe.Pointer rather than uintptr. #230

dmitshur opened this issue Oct 22, 2018 · 2 comments
Labels
glfw-3.3

Comments

@dmitshur
Copy link
Member

The motivation is to be able to get rid of the possible misuse of unsafe.Pointer messages from go vet, due to user being forced to convert uintptr back to unsafe.Pointer.

See discussion around go-gl/gl#113 (comment). /cc @slimsag

If we're in agreement this is a good idea and the right way forward, the question will be whether to do this for 3.2 (a breaking API change), or 3.3 only (still in development).
@dmitshur dmitshur mentioned this issue Oct 22, 2018
Closed
@tapir
Copy link
Member

tapir commented Oct 23, 2018

I'm OK with the change for 3.3 branch.
As it's not a bug I would not like to break API for 3.2

@tapir tapir added the glfw-3.3 label Apr 8, 2019
pwaller pushed a commit that referenced this issue Nov 24, 2019
@pchampio @pwaller
Add support for GLFW 3.3 (#256)
e5ec435 
GLFW tag 3.3-stable @ glfw/glfw@e4e9581

* Fix C Include & address GLFW v3.3 removals
* Glfw moved away from posix_tls.c to posix_thread.c (this reflects that they now contain more than TLS)
* Glfw moved away from win32_tls.c to win32_thread.c (same as above)
* Glfw removed wayland-.*-unstable-v1-client-protocol.c
* Glfw added wl_platform.h
* Glfw removed GLFW_USE_RETINA, _GLFW_USE_CHDIR and _GLFW_USE_MENUBAR compile-time macros
* Glfw removed support for MIR
* Address deprecations of glfw 3.3
* Glfw deprecate glfwSetCharModsCallback
* Glfw deprecate the window parameter of glfwGetClipboardString and
  glfwSetClipboardString, NULL can be used as the window argument
* Add glfw.SetClipboardString(string) and glfw.GetClipboardString()
  function (no Window type required)
* Use casting and clang-format c code
* Use casting instead of callback in C helpers (same as #219)
* Update travis
* Fix Darwin build tag

Fixes: #245, #255, #240, #230, #170
@pwaller
Copy link
Member

pwaller commented Nov 24, 2019

Hopefully this is addressed in #256, which introduces glfw 3.3 support. If not please report back and we can reopen.

@dmitshur I can confirm that go vet doesn't emit any warnings for me on Linux. Does that prove that this issue is resolved? It would be helpful to have a minimal reproducer to check.

@pwaller pwaller closed this as completed Nov 24, 2019
@pchampio pchampio mentioned this issue Nov 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
glfw-3.3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tapir @pwaller @dmitshur