-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Unclear repository update time: some inactive or archived repositories may get a recent "update time" #32046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This comment has been minimized.
This comment has been minimized.
Changing your repo settings also counts as "updated now". |
Scheduled actions also mark repo as updated, issue comments, PRs, and many other interactions with the repo can mark a repo as updated. |
Having the same issue. I'm browsing unauthenticated, yet repos are showing updated after I do so. When checking inside the repo, nothing has changed. |
Any operation which will update the record in DB of this repo will update the updated time. So it doesn't mean the code has been |
Just accessing some inactive repo will also update the updated time. I found this behavior pretty annoying. Is it possible to do the update at least only when something visible happens, e.g. issue comments, pr, setting changes mentioned above? |
So we need to clarify which kind operations should be considered as updated.
|
This comment has been minimized.
This comment has been minimized.
I recently discovered this phenomenon: when I just browsed the source code of some repositories through the web (without making any changes), the latest update time of some of the browsed repositories would show Updated 1 minutes ago under the Explore page. However, this is not the case for every browsed repository, which seems to be sporadic rather than inevitable.
|
@dsyx @lunny |
XORM's design is quite hacky, it does too much unnecessary things for developers. Actually it should never auto update anything. |
@yp05327 |
@dsyx |
Actions being run (including scheduled runs), issues/prs/comments being created, and other interactions that aren't git push also update the time. There was an issue with a minor release where viewing the repo did update that time, but IIRC it was quickly patched. it is possible the version you are/were on included that issue. Are you able to update to the latest stable version (at the time of writing it it 1.22.6)? |
I do not know what "issue" you refer to. If you mean #33119, that issue is unlikely in 1.22 and the "quick patch" is also only in 1.23/main. |
@techknowlogick |
I am running 1.23.1, and merely viewing the main page of a repository bumped its "updated" time to the current time. This is not covered by the options given in #32046 (comment). It seems to only happen when viewing repositories that have not been interacted with for a long time. It only happens on the first access, subsequent accesses do not further update the "updated" time. |
The bug was never really resolved. See https://gitea.com/gitea (root problem is #32046 (comment), and also #32046 (comment)) |
After some tests on Github, looks like only git related operations(push commits, create/delete branches, create/delete tags) will update the time. I think we can follow this behaviour. |
As far as I'm concerned, I would be totally okay if other clear "write" operations (open issue, comment on PR, etc.) would also bump the "updated" time. It is just strange that simply viewing a repository page can do that. |
I have sent #34388 to follow GH's behavior. What do you think about that? |
Only updating on git write operations is a reasonable and straightforward way of doing things, so I would also be happy with that. |
Description
internally hosted gitea instance mentioned my repo is updated 1 hour ago. i didnt do anything and there's no updated information inside the git.
Gitea Version
1.22
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
ubuntu 24.04
How are you running Gitea?
docker gitea instance. is there some backdoor to this?
Database
MySQL/MariaDB
The text was updated successfully, but these errors were encountered: