Skip to content

Release attachments are shown with incorrect URL on release pages #14324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 5 tasks
congoblue opened this issue Jan 13, 2021 · 2 comments
Closed
1 of 5 tasks

Release attachments are shown with incorrect URL on release pages #14324

congoblue opened this issue Jan 13, 2021 · 2 comments

Comments

@congoblue
Copy link

Description

When a file is manually attached to a release, on the release page Gitea uses a URL with a guid number to link to the file. This means you cannot right-click - save-as because the file saves with a numeric name and no extension rather than its correct filename as displayed on the release page.

http://giteaurl/attachments/69d80049-7826-4e98-9328-b87f43ff6d63

The attached file should be linked with a github-style URL like this to enable downloading and url sharing
http://giteaurl/organization/repo/releases/download/releasetag/filename.xxx

If you enter this style of URL manually in the browser, then Gitea does serve the correct file, so it appears the only problem is the URL being used on the page, the functionality being used to serve the file is all working.

Screenshots

image

@congoblue
Copy link
Author

Slight update to the comments above - if I put a test download link on a separate webpage in the correct form
http://giteaurl/organization/repo/releases/download/releasetag/filename.xxx

Gitea does serve the correct file but still with the guid-style numeric name, so right clicking and doing save-as still does not work - I assume the numeric filename must be set in the content-disposition of the response. So it is not just as simple as putting the correct link on the Releases page.

@noerw noerw removed the type/bug label Jan 17, 2021
@noerw
Copy link
Member

noerw commented Jan 17, 2021

duplicate of #10919

@noerw noerw closed this as completed Jan 17, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants