Pull API returning null

[jolheiser]

• Gitea version (or commit ref): 51f6a7a
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
    https://gitea.com/api/swagger#/repository/repoGetPullRequest

owner = gitea
repo = go-sdk
index = 217

Description

I deleted my fork of go-sdk and now the API call is "failing" because it returns nil.
Note "failing" because it does return a response, but it's null.

This is the offending func:

gitea/modules/convert/pull.go

Line 18 in 3c8a5d8

func ToAPIPullRequest(pr *models.PullRequest) *api.PullRequest {

Shouldn't be too hard to fix, but we need to distinguish what qualifies returning nil rather than as much data as possible, because currently returning null in the JSON response means PRs will get missed by services using API calls.

[zeripath]

So presumably the problem is here:

gitea/modules/convert/pull.go

Lines 39 to 43 in 3c8a5d8

	pr.HeadRepo, err = models.GetRepositoryByID(pr.HeadRepoID)
	if err != nil {
	log.Error("GetRepositoryById[%d]: %v", pr.ID, err)
	return nil
	}

One you've deleted your head repo that will return an ErrRepoNotExist. That should just be ignored and the nil repo coped with here:

gitea/modules/convert/pull.go

Lines 102 to 129 in 3c8a5d8

	headBranch, err = repo_module.GetBranch(pr.HeadRepo, pr.HeadBranch)
	if err != nil {
	if git.IsErrBranchNotExist(err) {
	apiPullRequest.Head = nil
	} else {
	log.Error("GetBranch[%s]: %v", pr.HeadBranch, err)
	return nil
	}
	} else {
	apiHeadBranchInfo := &api.PRBranchInfo{
	Name: pr.HeadBranch,
	Ref: pr.HeadBranch,
	RepoID: pr.HeadRepoID,
	Repository: pr.HeadRepo.APIFormat(models.AccessModeNone),
	}
	headCommit, err = headBranch.GetCommit()
	if err != nil {
	if git.IsErrNotExist(err) {
	apiHeadBranchInfo.Sha = ""
	} else {
	log.Error("GetCommit[%s]: %v", headBranch.Name, err)
	return nil
	}
	} else {
	apiHeadBranchInfo.Sha = headCommit.ID.String()
	}
	apiPullRequest.Head = apiHeadBranchInfo
	}