Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

printf -v is not available in some shells #34

Open
sparr opened this issue Sep 20, 2024 · 0 comments
Open

printf -v is not available in some shells #34

sparr opened this issue Sep 20, 2024 · 0 comments

Comments

@sparr
Copy link

sparr commented Sep 20, 2024

There are four instances of printf -v in funclib.sh (e.g. https://github.com/gnulib-modules/bootstrap/blob/master/build-aux/funclib.sh#L1156) which do not work in the dash shell. Although that file doesn't specify #!/bin/sh, the bootstrap script it ends up included in does. These printf -v var ... should be replaced with var="$(printf ...)" which will allow the tests in question to proceed on dash and potentially get a faster func_quotefast_eval than the fallback.

See: https://salsa.debian.org/debian/devscripts/-/blob/main/scripts/checkbashisms.pl?ref_type=heads#L706 (against which I'll be submitting a patch about the quoting shortly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant