Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure SetOption is only callable if the server has not been started yet #20

Open
belak opened this issue Feb 4, 2017 · 5 comments
Open

Ensure SetOption is only callable if the server has not been started yet #20

belak opened this issue Feb 4, 2017 · 5 comments
Labels
bug help wanted

Comments

@belak
Copy link
Collaborator

belak commented Feb 4, 2017

Optionally, make a copy when calling makeConfig so the running server config can't be modified.
@progrium
Copy link
Contributor

progrium commented Feb 4, 2017

Even better.

@hloeffler
Copy link
Contributor

+1 for copy, will help if multiple servers are used, with different config.
and please first add test for it

belak added a commit to atlassian/go-ssh that referenced this issue Feb 6, 2017
@belak
Add support for cleanly shutting down a server
be0f343 
This is related to gliderlabs#22 and gliderlabs#20
@belak belak mentioned this issue Feb 6, 2017
Closed
belak added a commit to atlassian/go-ssh that referenced this issue Feb 6, 2017
@belak
Add support for cleanly shutting down a server
6cd286b 
This is related to gliderlabs#22 and gliderlabs#20
belak added a commit to atlassian/go-ssh that referenced this issue Feb 15, 2017
@belak
Add support for cleanly shutting down a server
cf103fe 
This is related to gliderlabs#22 and gliderlabs#20
belak added a commit to atlassian/go-ssh that referenced this issue Feb 16, 2017
@belak
Add support for cleanly shutting down a server
db345bb 
This is related to gliderlabs#22 and gliderlabs#20
belak added a commit to atlassian/go-ssh that referenced this issue Mar 9, 2017
@belak
Add support for cleanly shutting down a server
ce408ac 
This is related to gliderlabs#22 and gliderlabs#20
@progrium
Copy link
Contributor

progrium commented Nov 1, 2017

Looks like we could still use a check if it's running in SetOption to bail if it's too late.

@josegonzalez
Copy link
Member

@progrium Do we want to use the srv.state idea @belak initially had in PR #23?

@progrium
Copy link
Contributor

Might be good to introduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@progrium @josegonzalez @belak @hloeffler