Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mobile version #117

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Improve mobile version #117

wants to merge 3 commits into from

Conversation

albizures
Copy link

Closes #86

Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Please explain your changes. I couldn't see how it helps with scrolling the code window? Thank you.

@albizures
Copy link
Author

Hello, sorry for not adding a description
The changes convert the prev-next area into a floating bar at the bottom, from which users can toggle what side is active, the idea is to have only one side (right or left) active at once.
The accomplish this I:

  • Added a main element so the prev-next can be outside of the playground, since one of the sides is going to be hidden in mobile.
  • Update prev-next styles to place it somewhat similar to how it was before
  • Added a new button to toggle right or left
    Since only one area is rendered at once each side will have the full size of the screen, and in the case of the right side at most of the cases it will have only one scroll, the one in the code panel

The only case where scrolling issue reported will happen again is if the log is too long. But to fix it I needed to make more changes and I think this was good enough for now 😄

I hope that explains it well.

And btw thanks for the great language @lpil !

@lpil
Copy link
Member

lpil commented Jul 18, 2024

Great! Thank you!

The styling of the buttons on desktop needs to be changed, it shouldn't have a floating box with rounded corners, it doesn't fit with the existing design.

When there is a lot of code or a lot of output the whole page scrolls on desktop. It should never scroll, rather the code and output sections should scroll.

On mobile the code section doesn't extend all the way to meet the header bar, there's a small gap and a border between them.

The "see code" and "see tutorial" links look a bit strange to me, being positioned with the navigation but having a very different purpose and different styling.

It seems this doesn't resolve #86 as it's still hard to scroll the code section on mobile when it has a scroll bar.

@lpil lpil marked this pull request as draft July 18, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difficulties navigating the tour on mobile
2 participants