Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config_writer().set_value stopped working #1548

Open
frobijn opened this issue Jan 25, 2023 · 1 comment
Open

config_writer().set_value stopped working #1548

frobijn opened this issue Jan 25, 2023 · 1 comment

Comments

@frobijn
Copy link

frobijn commented Jan 25, 2023

Since a recent update of GitPython execution of the method:

<repo>.config_writer().set_value("core", "longpaths", "true").release()

fails with error message "--config is not allowed, use allow_unsafe_options=True to allow it."

The message was added by the 24 december 2022 commit of https://github.com/gitpython-developers/GitPython/commits/main/git/cmd.py when a check for unsafe options was introduced. No changes have been made to the methods of the config_writer to compensate for the check for unsafe options, so presumably they all will fail (at least the set_value method does).

@Byron
Copy link
Member

Byron commented Jan 25, 2023

Thanks for reporting! It seems there is no test covering making changes to configuration files then.

I hope a fix can be contributed that adds a test, and the fix by allowing these unsafe options when writing configuration files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants