Skip to content

Commit 2e0d835

Browse files
authored
Merge pull request #2045 from EliahKagan/shell-warning-refactor
Clarify `USE_SHELL` warning helper signature
2 parents b6a188b + 253099f commit 2e0d835

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

git/cmd.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -550,7 +550,7 @@ def __del__(self) -> None:
550550
)
551551

552552

553-
def _warn_use_shell(extra_danger: bool) -> None:
553+
def _warn_use_shell(*, extra_danger: bool) -> None:
554554
warnings.warn(
555555
_USE_SHELL_DANGER_MESSAGE if extra_danger else _USE_SHELL_DEFAULT_MESSAGE,
556556
DeprecationWarning,
@@ -566,12 +566,12 @@ class _GitMeta(type):
566566

567567
def __getattribute(cls, name: str) -> Any:
568568
if name == "USE_SHELL":
569-
_warn_use_shell(False)
569+
_warn_use_shell(extra_danger=False)
570570
return super().__getattribute__(name)
571571

572572
def __setattr(cls, name: str, value: Any) -> Any:
573573
if name == "USE_SHELL":
574-
_warn_use_shell(value)
574+
_warn_use_shell(extra_danger=value)
575575
super().__setattr__(name, value)
576576

577577
if not TYPE_CHECKING:
@@ -988,7 +988,7 @@ def __init__(self, working_dir: Union[None, PathLike] = None) -> None:
988988

989989
def __getattribute__(self, name: str) -> Any:
990990
if name == "USE_SHELL":
991-
_warn_use_shell(False)
991+
_warn_use_shell(extra_danger=False)
992992
return super().__getattribute__(name)
993993

994994
def __getattr__(self, name: str) -> Any:

0 commit comments

Comments
 (0)