[go] Add golangci-lint to the env manifest #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cannot start job - please talk to whoever's in charge of your Werft installation |
mads-hartmann
requested changes
Nov 22, 2022
There was a problem hiding this comment.
Code change LGTM but tests appear to be failing at the moment. Example log output:
unepxected exit code: expected 0, actual 1 (stderr: time="2022-11-22T10:55:07Z" level=fatal msg="cannot resolve env manifest entry golangci-lint: exec: \"golangci-lint\": executable file not found in $PATH"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds golangci-lint to the env manifest.
Related Issue(s)
Fixes #132
How to test
Release Notes