Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "resolutions" in typescript libraries #12

Open
geropl opened this issue May 20, 2020 · 1 comment
Open

Support "resolutions" in typescript libraries #12

geropl opened this issue May 20, 2020 · 1 comment

Comments

@geropl
Copy link
Member

geropl commented May 20, 2020

Currently only the local package.json is copied into the build directory. Because the workspace global package.json (with it's resolutions fields) is missing package resolution behaves different to outside of leeway.

One way to "fix" this would be to add a config workspaceRootPackageJson and merge that into the local package.json.

/cc @akosyakov

@geropl
Copy link
Member Author

geropl commented Sep 2, 2020

Also @AlexTugarev discovered that the installer-package.json which we generate to install Typescript packages does not contain the resolutions from the package it installs. This seems to have the effect that yarn ignores the resolutions (at least in case they do not match the version patterns) which leads to different build results (breaking builds).

If the above is true there are two (closely related) tasks here:

  • Merge resolutions from the workspace root package.json into typescript packages
  • Copy resolutions from each Typescript package into it's installer-package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant