Add support for optional depednencies #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #103 +/- ##
========================================
+ Coverage 7.36% 7.69% +0.32%
========================================
Files 19 19
Lines 2893 2912 +19
========================================
+ Hits 213 224 +11
- Misses 2648 2656 +8
Partials 32 32 |
mads-hartmann
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
The code changes look good to me, but I'm not sure if this fixes #100 - I left a comment on the issue to explain further here - it would be nice to reproduce the error on main first and then show that it still works when the package is marked as optional and the BUILD.js is modified to only add the package if a build flag is set.
| return segs[0], segs[1] | ||
| } | ||
|
|
||
| // Component returns the component of the depdency |
There was a problem hiding this comment.
Nit: Small typo
Suggested change
| // Component returns the component of the depdency | |
| // Component returns the component of the dependency |
|
Closed because of #100 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for optional dependencies. This is useful in conjunction with dynamic packages.
Related Issue(s)
Fixes #100
How to test
Have a dependency to a package which doesn't exist and mark it optional, e.g. like in leeways workspace.