Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

fail in step 5 again with a message "1 snapshot obsolete." #57

Open
dzeyelid opened this issue Jun 11, 2021 · 3 comments
Open

fail in step 5 again with a message "1 snapshot obsolete." #57

dzeyelid opened this issue Jun 11, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@dzeyelid
Copy link

dzeyelid commented Jun 11, 2021

Bug Report

Current behavior

After responding activity of step 5, github-learning-lab mentions the Actions cannot finish the workflow correctly.

In the workflow result, a warning was raised by npm run test. The warning says "Snapshot is obsolete".

FYI, This relates with #55. I solved the problem directly on githubtraining/using-github-actions-for-ci-template#15, but the next problem appeared now.

Reproduction
Same as #55

Expected behavior
Same as #55

Possible solution
I solve with fixing the code and updating the snapshot in githubtraining/using-github-actions-for-ci-template#17.

Additional context
My learning lab practice repo that this problem is produced is here.
https://github.com/dzeyelid/github-actions-for-ci_keep2/pull/2

The problem position is here.
https://github.com/dzeyelid/github-actions-for-ci_keep2/pull/2#issuecomment-859223483

@dzeyelid dzeyelid added the bug Something isn't working label Jun 11, 2021
@brianamarie
Copy link
Contributor

Thank you for your continued work on this, @dzeyelid! ✨ I can't thank you enough.

Given that the course is already broken, as before, I'm going to go ahead and prioritize merging #17. For ease of troubleshooting, I'm going to merge #17 first, then let's touch base to see if things are working as expected and look at #18. Does that sound okay to you @dzeyelid?

@dzeyelid
Copy link
Author

I also think your suggestion is good. Thank you for the priority triage.

@dzeyelid
Copy link
Author

@brianamarie I found the updated snapshot in my previous PR githubtraining/using-github-actions-for-ci-template#17 is not suited for the current main branch. I'm so sorry!

The difference seems to be caused by @babel/core version. The version of that in main branch is @babel/[email protected], but the version in my environment is @babel/[email protected].

I create a pull request githubtraining/using-github-actions-for-ci-template#19 to revert the snapshot. Please check it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants