Enable template substitution and safeinputs proxying in AWMG gateway#8700
Enable template substitution and safeinputs proxying in AWMG gateway#8700
Conversation
- Apply os.ExpandEnv to URL, headers, and env fields in MCP server configs - Remove filtering of safeinputs/safeoutputs servers - they are now proxied - Update tests to reflect new behavior - All tests passing Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
🎉 Yo ho ho! Smoke Copilot Safe Inputs found the treasure and completed successfully! ⚓💰 |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
✅ Firewall validation complete... Smoke Codex Firewall confirmed network sandboxing is operational. 🛡️ |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
🤖 DIAGNOSTIC COMPLETE: Smoke Copilot No Firewall STATUS: ALL_UNITS_OPERATIONAL. MISSION_SUCCESS. |
|
📰 VERDICT: Smoke Copilot Playwright has concluded. All systems operational. This is a developing story. 🎤 |
Copilot Smoke Test ResultsLast 2 merged PRs:
Test Results:
Overall Status: ✅ PASS @pelikhan (PR author/assignee)
|
|
MCP merged PR titles: Security Fix: Prevent path traversal in shell completion config file reads (Alerts #444, #443); Resolve Setup action tags to SHAs in release mode using action pin manager
|
Smoke Test Results: FAIL❌ Playwright MCP: Tool not available in environment Status: FAIL - 1/3 tests passed
|
Smoke Test Results (Claude Sonnet 4.5)Last 2 merged PRs:
Test Results:
Status: PASS (5/6 tests passed; safeinputs-gh not configured)
|
|
PRs: #8699 "Security Fix: Prevent path traversal in shell completion config file reads (Alerts #444, #443)", #8694 "Resolve Setup action tags to SHAs in release mode using action pin manager"
|
The AWMG gateway needs to expand
${VAR}template expressions in MCP server configurations and proxy safeinputs/safeoutputs servers.Changes
os.ExpandEnv()to URL, headers, and env fields during config parsingExample
Configuration with template expressions:
{ "mcpServers": { "safeinputs": { "type": "http", "url": "http://localhost:${GH_AW_SAFE_INPUTS_PORT}", "headers": { "Authorization": "Bearer ${GH_AW_SAFE_INPUTS_API_KEY}" } } } }With environment variables set (
GH_AW_SAFE_INPUTS_PORT=3000,GH_AW_SAFE_INPUTS_API_KEY=secret), the gateway now:http://localhost:8080/mcp/safeinputsTest Coverage
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.