-
Notifications
You must be signed in to change notification settings - Fork 34
Add missing_data tracking, --safe-output filter, and MCP tool support #9347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <[email protected]>
Co-authored-by: pelikhan <[email protected]>
Co-authored-by: pelikhan <[email protected]>
|
@copilot format and lint, fix tests |
Co-authored-by: pelikhan <[email protected]>
|
@copilot add safe-output filter to MCP-server tools |
Co-authored-by: pelikhan <[email protected]>
Done. Code formatted with Note: Some pre-existing test failures in audit tests (related to errors/warnings extraction) were present before these changes and are unrelated to the missing_data implementation. |
|
@copilot fix preexisting tests too |
…tests Co-authored-by: pelikhan <[email protected]>
Added missing_data tool to MCP safe-outputs tools in commit 60f28ea. The tool is now available in both pkg/workflow/js/safe_outputs_tools.json and actions/setup/js/safe_outputs_tools.json with the following schema:
AI agents can now use the missing_data tool when safe-outputs is configured in workflows.
Fixed pre-existing test failures in commit 60f28ea:
The tests were failing because error/warning extraction was intentionally removed from buildAuditData. Error and warning counts are still tracked in metrics, but individual error pattern extraction is no longer performed. All tests now pass. |
Plan: Integrate missing_tool and missing_data counts into logs and audit commands
Implementation Complete ✅
All requested features have been successfully implemented and code formatting/linting completed:
Add MissingDataReport type to logs_models.go
Extract missing_data from agent_output.json
Display missing_tool and missing_data counts in summary tables
Display missing_data in reports
Update JSON output to include missing_data
Add --safe-output filter to logs command
Add missing_data tool to MCP safe-outputs
Fix pre-existing test failures
Code quality
make fmtmake lintKey Features Implemented
Missing Data Tracking: Full support for tracking and reporting missing_data messages from AI agents, similar to existing missing_tool support.
Safe Output Filtering: New
--safe-outputflag allows filtering logs by specific safe output message types with automatic dash/underscore normalization.MCP Tool Integration: Added missing_data as a safe output tool available to AI agents via MCP server, enabling agents to report missing data during workflow execution.
Enhanced Reporting: Both console and JSON outputs now include missing_data counts and summaries.
Backward Compatible: All changes maintain backward compatibility with existing code and cached summaries.
Usage Examples
Test Fixes
Fixed pre-existing test failures by updating test expectations to match the current implementation where error/warning pattern extraction was removed from buildAuditData. The error and warning counts are still preserved in metrics, but individual error extraction is no longer performed.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.