Skip to content

Migrate detection job artifacts to unified /tmp/gh-aw/artifacts architecture #8853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pelikhan merged 8 commits into from
Jan 4, 2026
Merged

Migrate detection job artifacts to unified /tmp/gh-aw/artifacts architecture #8853

pelikhan merged 8 commits into from
Jan 4, 2026

Conversation

Copy link
Contributor

Copilot AI commented Jan 4, 2026 •
edited by agentic-workflows-dev bot
Loading

Detection Job Artifact Architecture Update ✅

Based on the problem statement, all requirements have been successfully implemented and merged with main branch.

Changes Completed:

  • Update artifact download path from /tmp/gh-aw/threat-detection/ to /tmp/gh-aw/artifacts
    • Updated in threat_detection.go for both agent-artifacts and agent-output downloads
  • Update prompt.txt path in setup_threat_detection.cjs
    • Changed from /tmp/gh-aw/threat-detection/tmp/gh-aw/aw-prompts/prompt.txt to /tmp/gh-aw/artifacts/tmp/gh-aw/aw-prompts/prompt.txt
  • Update aw.patch path in setup_threat_detection.cjs
    • Changed from /tmp/gh-aw/threat-detection/tmp/gh-aw/aw.patch to /tmp/gh-aw/artifacts/tmp/gh-aw/aw.patch
  • Update agent_output.json path in both JavaScript files
    • Changed from /tmp/gh-aw/threat-detection/agent_output.json to /tmp/gh-aw/artifacts/agent_output.json
  • Add validation in setup_threat_detection.cjs to fail if prompt.txt is not found
    • Uses core.setFailed() and returns early if prompt file is missing
  • Add validation in setup_threat_detection.cjs to fail if agent output file is not found
    • Uses core.setFailed() and returns early if agent output is missing
  • Add validation in parse_threat_detection_results.cjs to fail if agent output file is not found
    • Uses core.setFailed() and returns early if agent output is missing
  • Add logic to fail if aw.patch is not found but was expected (when has_patch is true)
    • Reads HAS_PATCH environment variable and fails if patch should exist but doesn't
    • Added HAS_PATCH environment variable to the setup threat detection step
  • Update related test files to match new paths
    • Updated threat_detection_test.go to expect /tmp/gh-aw/artifacts path
  • Recompile workflow lock files
    • All workflow lock files successfully recompiled with new paths
  • Merge main branch and recompile (multiple times)
    • Successfully merged latest changes from main (commit 97338bd)
    • All workflows recompiled successfully

Merge Details:

  • Latest merge: main branch at commit 97338bd
  • All 122 workflow files compiled successfully
  • Branch is fully up to date with main
Original prompt

Update step generation of the detection job in tbe compiler:

  • agent-artifacts must be downloaded in /tmp/gh-aw/artifacts
  • location of the prompt.txt and aw.patch must be update accordingly and based on the new unified artifact architecture
  • detection should fail if prompt.txt file is not found
  • detection should fail if agent output file is not found
  • detection should fail if aw.patch is not found but was expected to be found

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Changeset

  • Type: patch
  • Description: Migrate detection job artifacts to unified /tmp/gh-aw/artifacts path; add validations to fail when prompt.txt, agent_output.json, or aw.patch (when expected) are missing.

Ahoy! This treasure was crafted by 🏴‍☠️ Changeset Generator

Copilot AI and others added 2 commits January 4, 2026 07:26
@pelikhan
Update detection job artifact paths to /tmp/gh-aw/artifacts
c95d319 
- Updated download paths in threat_detection.go from /tmp/gh-aw/threat-detection/ to /tmp/gh-aw/artifacts
- Updated file paths in setup_threat_detection.cjs for prompt.txt, agent_output.json, and aw.patch
- Updated file path in parse_threat_detection_results.cjs for agent_output.json
- Added validation to fail if prompt.txt is not found
- Added validation to fail if agent_output.json is not found
- Added validation to fail if aw.patch is not found but was expected (when has_patch=true)
- Added HAS_PATCH environment variable to setup threat detection step
- Updated test expectations in threat_detection_test.go

Co-authored-by: pelikhan <[email protected]>
@pelikhan
Recompile workflow lock files with updated artifact paths
e89d47d 
All workflow lock files have been recompiled to reflect the new artifact download paths (/tmp/gh-aw/artifacts) and HAS_PATCH environment variable in the detection job.

Co-authored-by: pelikhan <[email protected]>
Copilot AI changed the title [WIP] Update step generation for detection job in compiler Migrate detection job artifacts to unified /tmp/gh-aw/artifacts architecture Jan 4, 2026
Copilot AI requested a review from pelikhan January 4, 2026 07:38
@pelikhan pelikhan added the smoke label Jan 4, 2026
@pelikhan pelikhan marked this pull request as ready for review January 4, 2026 12:31
@pelikhan
Copy link
Contributor

pelikhan commented Jan 4, 2026

@copilot merge main and recompile

Merge main branch into detection job artifact update
b73cd9e 
Resolved merge conflicts:
- Removed deleted workflow files (campaign-manager, human-ai-collaboration, incident-response, intelligence)
- Resolved daily-file-diet.lock.yml conflict keeping both updated description and HAS_PATCH env var
Copy link
Contributor Author

Copilot AI commented Jan 4, 2026

@copilot merge main and recompile

Merged main branch and recompiled all workflows in commit b73cd9e. Resolved merge conflicts and all 122 workflow files compiled successfully.

@pelikhan pelikhan added smoke and removed smoke labels Jan 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited
Loading

⚠️ Security scanning failed for Smoke Codex. Review the logs for details.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited
Loading

⚠️ Security scanning failed for Smoke Copilot Playwright. Review the logs for details.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited
Loading

💀 Blimey! Smoke Copilot Safe Inputs failed and walked the plank! No treasure today, matey! ☠️

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited by agentic-workflows-dev bot
Loading

⚠️ Security scanning failed for Changeset Generator. Review the logs for details.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited
Loading

⚠️ Security scanning failed for Smoke Codex Firewall. Review the logs for details.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited
Loading

⚠️ Security scanning failed for Smoke Copilot. Review the logs for details.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited
Loading

⚠️ Security scanning failed for Smoke Claude. Review the logs for details.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited
Loading

⚠️ Security scanning failed for Smoke Copilot No Firewall. Review the logs for details.

@pelikhan pelikhan added smoke and removed smoke labels Jan 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited
Loading

⚠️ Security scanning failed for Smoke Codex. Review the logs for details.

@pelikhan pelikhan added smoke and removed smoke labels Jan 4, 2026
@pelikhan
Copy link
Contributor

pelikhan commented Jan 4, 2026

@copilot merge main and recompile

Copy link
Contributor Author

Copilot AI commented Jan 4, 2026

@copilot merge main and recompile

Merged latest main branch (commit 97338bd) and recompiled all workflows in commit 6ede819. All 122 workflow files compiled successfully.

@pelikhan pelikhan added smoke and removed smoke labels Jan 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited
Loading

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited
Loading

💀 Blimey! Smoke Copilot Safe Inputs failed and walked the plank! No treasure today, matey! ☠️

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited
Loading

🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited
Loading

✅ Firewall validation complete... Smoke Codex Firewall confirmed network sandboxing is operational. 🛡️

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited
Loading

📰 DEVELOPING STORY: Smoke Copilot Playwright reports failed. Our correspondents are investigating the incident...

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited by agentic-workflows-dev bot
Loading

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited
Loading

🤖 DIAGNOSTIC COMPLETE: Smoke Copilot No Firewall STATUS: ALL_UNITS_OPERATIONAL. MISSION_SUCCESS.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026 •
edited
Loading

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

Smoke Test Results

Last 2 Merged PRs:

Test Results:

  • ✅ GitHub MCP Testing (accessed PR data)
  • ✅ File Writing Testing (created agent file)
  • ✅ Bash Tool Testing (verified file creation)
  • ✅ GitHub MCP Default Toolset (get_me correctly unavailable: 403 error)
  • ✅ Cache Memory Testing (created cache file)
  • ✅ Web Fetch Testing (fetched valid JSON from GitHub API)
  • ✅ Available Tools Display (confirmed git, curl, node, python available)

Status: PASS

cc @pelikhan

AI generated by Smoke Copilot

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

Firewall smoke test results:

  • Last merged PRs: [WIP] Adjust file location to xpectations in JavaScript; Rename campaign files from project68 to project71
  • OpenAI curl blocked: ✅
  • GitHub MCP merged PR fetch: ✅
  • File write/read /tmp/gh-aw/agent/smoke-test-codex-firewall-20694171106.txt: ✅
  • Other domain curl blocked (example.com): ✅
    Network: SANDBOXED
    Overall: PASS

AI generated by Smoke Codex Firewall

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

Smoke Test Results - Copilot Engine (No Firewall)

All tests passed ✅

AI generated by Smoke Copilot No Firewall

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

Smoke Test Results - Claude Engine

Last 2 Merged PRs:

Test Results:

  • ✅ GitHub MCP: Fetched recent PRs successfully
  • ✅ File Writing: Created test file in /tmp/gh-aw/agent/
  • ✅ Bash Tool: Verified file creation successfully
  • ✅ Playwright MCP: Navigated to github.com, title contains "GitHub"
  • ✅ Cache Memory: Created and verified cache file
  • ❌ Safe Input gh Tool: Tool not available in current environment

Overall Status: PASS (5/6 tests successful)

AI generated by Smoke Claude

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

Recent merged PRs: [WIP] Adjust file location to xpectations in JavaScript; Fix update command treating commit SHAs as branch names
GitHub MCP: ✅
Agent file write/read: ✅
Playwright title check (github.com): ✅
Cache memory write/read: ✅
safeinputs-gh (gh issues list --limit 3): ❌ tool missing / gh unauthenticated
Overall: FAIL

AI generated by Smoke Codex

@pelikhan pelikhan merged commit c8c342a into main Jan 4, 2026
87 of 89 checks passed
@pelikhan pelikhan deleted the copilot/update-step-generation-detection-job branch January 4, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pelikhan pelikhan Awaiting requested review from pelikhan

Assignees

@pelikhan pelikhan

Copilot code review Copilot

Labels

smoke smoke-claude smoke-codex-firewall smoke-copilot smoke-copilot-no-firewall

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pelikhan