Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 4, 2026

Agent artifacts have been consolidated into a single agent-artifacts artifact at /tmp/gh-aw/. Tests were still expecting the old separate artifact structure where patches lived in aw-patch/aw.patch, and PR helper instructions were still referencing the old artifact name.

Changes

  • Updated test artifact setup to use unified structure:

    • TestMultipleArtifactFlattening in logs_awinfo_resolution_test.go
    • TestFlattenSingleFileArtifactsWithAuditFiles in logs_flatten_test.go
    • TestAuditCanFindFlattenedArtifacts in logs_flatten_test.go
  • Changed test expectations from separate artifacts to unified artifact:

    • OLD: aw-patch/aw.patch, aw-info/aw_info.json, etc.
    • NEW: agent-artifacts/tmp/gh-aw/aw.patch, agent-artifacts/tmp/gh-aw/aw_info.json, etc.
  • Switched flattening functions from flattenSingleFileArtifacts() to flattenUnifiedArtifact() where appropriate

  • Updated PR helper artifact download instructions:

    • actions/setup/js/create_pull_request.cjs: Changed artifact download from gh run download -n aw.patch to gh run download -n agent-artifacts with correct path agent-artifacts/tmp/gh-aw/aw.patch
    • specs/safe-output-messages.md: Updated documentation examples to match the unified artifact structure

The production code already handles both structures correctly via flattenUnifiedArtifact() in the download logic. This change updates test expectations and user-facing instructions to match the current artifact upload implementation.

Original prompt

Reference: https://github.com/githubnext/gh-aw/actions/runs/20688222777/job/59392578012#step:6:1

The agent artifact has been unified into a single artifact agent-artifacts in /tmp/gh-aw/. There is no more aw patch artifact and you should update the location where the patch is downloaded from the agent artifact folders.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.


Changeset

  • Type: patch
  • Description: Update tests and PR helper instructions to use the unified agent-artifacts artifact layout under /tmp/gh-aw/. Tests now expect artifacts under agent-artifacts/tmp/gh-aw/ (e.g. agent-artifacts/tmp/gh-aw/aw.patch, agent-artifacts/tmp/gh-aw/aw_info.json) and were switched to use flattenUnifiedArtifact() where appropriate.

Ahoy! This treasure was crafted by 🏴‍☠️ Changeset Generator

Copilot AI changed the title [WIP] Update location for downloading agent artifacts Update tests for unified agent artifact structure Jan 4, 2026
Copilot AI requested a review from pelikhan January 4, 2026 05:55
@pelikhan
Copy link
Contributor

pelikhan commented Jan 4, 2026

@copilot update JavaScript logic in pr helpers to find the aw.patch file

Update artifact download instructions in create_pull_request.cjs and documentation to reflect that patches are now in the unified agent-artifacts artifact at agent-artifacts/tmp/gh-aw/aw.patch instead of a separate aw.patch artifact.

Co-authored-by: pelikhan <[email protected]>
Copy link
Contributor Author

Copilot AI commented Jan 4, 2026

@copilot update JavaScript logic in pr helpers to find the aw.patch file

Updated the artifact download instructions in commit 54a92b7. Changed from gh run download -n aw.patch to gh run download -n agent-artifacts with the correct path agent-artifacts/tmp/gh-aw/aw.patch for applying the patch.

Copilot AI changed the title Update tests for unified agent artifact structure Update tests and PR helpers for unified agent artifact structure Jan 4, 2026
@pelikhan pelikhan added the smoke label Jan 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

✅ Firewall validation complete... Smoke Codex Firewall confirmed network sandboxing is operational. 🛡️

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

🎉 Yo ho ho! Smoke Copilot Safe Inputs found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

🎬 THE ENDSmoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

📰 VERDICT: Smoke Copilot Playwright has concluded. All systems operational. This is a developing story. 🎤

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

🤖 DIAGNOSTIC COMPLETE: Smoke Copilot No Firewall STATUS: ALL_UNITS_OPERATIONAL. MISSION_SUCCESS.

@pelikhan pelikhan marked this pull request as ready for review January 4, 2026 06:11
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

AI generated by Smoke Codex Firewall

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

Smoke Test Results (Run 20688664597)

Last 2 Merged PRs:

Test Results:

  • ✅ GitHub MCP Testing
  • ✅ File Writing
  • ✅ Bash Tool
  • ✅ GitHub MCP Default Toolset (confirmed get_me NOT available)
  • ✅ Cache Memory
  • ✅ Web Fetch

Status: PASS

cc: @pelikhan

AI generated by Smoke Copilot

@pelikhan pelikhan merged commit e239bec into main Jan 4, 2026
49 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

Smoke Test Results

Test 1 - File Writing: ✅ Created and verified /tmp/gh-aw/agent/smoke-test-copilot-20688664576.txt
Test 2 - Bash Tool: ✅ Successfully executed bash commands and read file back
Test 3 - Safe Input gh Tool: ❌ Cannot test - safeinputs-gh tool not available in current workflow

Overall Status: FAIL (1/3 tests passed)

Note: The safeinputs-gh tool is not configured in this workflow's available tools.

AI generated by Smoke Copilot Safe Inputs

@pelikhan pelikhan deleted the copilot/update-agent-artifact-location branch January 4, 2026 06:12
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

Smoke Test Results - Copilot Engine (No Firewall)

✅ All tests passed successfully

  • ✅ GitHub API access via safeinputs-gh tool
  • ✅ File creation in temporary directory
  • ✅ Playwright browser automation
  • ✅ Network connectivity without firewall restrictions

AI generated by Smoke Copilot No Firewall

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

Smoke Test Results (Run #20688664575)

Playwright MCP: Not available in environment
Cache Memory: Successfully wrote and verified test file
safeinputs-gh Tool: Command not found

Overall Status: FAIL

Note: Test environment missing expected tools (Playwright MCP, safeinputs-gh).

AI generated by Smoke Copilot Playwright

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

Smoke test results:

AI generated by Smoke Codex

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

Smoke Test Results

Last 2 Merged PRs:

Test Results:

  • ✅ GitHub MCP: Retrieved recent PRs
  • ✅ File Writing: Created /tmp/gh-aw/agent/smoke-test-claude-20688664560.txt
  • ✅ Bash Tool: Verified file contents successfully
  • ✅ Playwright MCP: Navigated to GitHub (title: "GitHub · Change is constant. GitHub keeps you ahead. · GitHub")
  • ✅ Cache Memory: Created /tmp/gh-aw/cache-memory/smoke-test-20688664560.txt
  • ❌ Safe Inputs gh Tool: Tool not available (reported missing)

Overall Status: PARTIAL PASS (5/6 tests passed)

AI generated by Smoke Claude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants