-
Notifications
You must be signed in to change notification settings - Fork 34
Update tests and PR helpers for unified agent artifact structure #8846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <[email protected]>
|
@copilot update JavaScript logic in pr helpers to find the aw.patch file |
Update artifact download instructions in create_pull_request.cjs and documentation to reflect that patches are now in the unified agent-artifacts artifact at agent-artifacts/tmp/gh-aw/aw.patch instead of a separate aw.patch artifact. Co-authored-by: pelikhan <[email protected]>
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
✅ Firewall validation complete... Smoke Codex Firewall confirmed network sandboxing is operational. 🛡️ |
|
🎉 Yo ho ho! Smoke Copilot Safe Inputs found the treasure and completed successfully! ⚓💰 |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
📰 VERDICT: Smoke Copilot Playwright has concluded. All systems operational. This is a developing story. 🎤 |
|
🤖 DIAGNOSTIC COMPLETE: Smoke Copilot No Firewall STATUS: ALL_UNITS_OPERATIONAL. MISSION_SUCCESS. |
|
Smoke Test Results (Run 20688664597)Last 2 Merged PRs:
Test Results:
Status: PASS cc: @pelikhan
|
Smoke Test ResultsTest 1 - File Writing: ✅ Created and verified Overall Status: FAIL (1/3 tests passed) Note: The
|
Smoke Test Results - Copilot Engine (No Firewall)✅ All tests passed successfully
|
Smoke Test Results (Run #20688664575)❌ Playwright MCP: Not available in environment Overall Status: FAIL Note: Test environment missing expected tools (Playwright MCP, safeinputs-gh).
|
|
Smoke test results:
|
Smoke Test ResultsLast 2 Merged PRs:
Test Results:
Overall Status: PARTIAL PASS (5/6 tests passed)
|
Agent artifacts have been consolidated into a single
agent-artifactsartifact at/tmp/gh-aw/. Tests were still expecting the old separate artifact structure where patches lived inaw-patch/aw.patch, and PR helper instructions were still referencing the old artifact name.Changes
Updated test artifact setup to use unified structure:
TestMultipleArtifactFlatteninginlogs_awinfo_resolution_test.goTestFlattenSingleFileArtifactsWithAuditFilesinlogs_flatten_test.goTestAuditCanFindFlattenedArtifactsinlogs_flatten_test.goChanged test expectations from separate artifacts to unified artifact:
aw-patch/aw.patch,aw-info/aw_info.json, etc.agent-artifacts/tmp/gh-aw/aw.patch,agent-artifacts/tmp/gh-aw/aw_info.json, etc.Switched flattening functions from
flattenSingleFileArtifacts()toflattenUnifiedArtifact()where appropriateUpdated PR helper artifact download instructions:
actions/setup/js/create_pull_request.cjs: Changed artifact download fromgh run download -n aw.patchtogh run download -n agent-artifactswith correct pathagent-artifacts/tmp/gh-aw/aw.patchspecs/safe-output-messages.md: Updated documentation examples to match the unified artifact structureThe production code already handles both structures correctly via
flattenUnifiedArtifact()in the download logic. This change updates test expectations and user-facing instructions to match the current artifact upload implementation.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Changeset
agent-artifactsartifact layout under/tmp/gh-aw/. Tests now expect artifacts underagent-artifacts/tmp/gh-aw/(e.g.agent-artifacts/tmp/gh-aw/aw.patch,agent-artifacts/tmp/gh-aw/aw_info.json) and were switched to useflattenUnifiedArtifact()where appropriate.