Refactor: Extract domain string formatting to reduce duplication

Co-authored-by: mnkiefer <[email protected]>

Author: Copilot

pkg/workflow/mcp-config.go

@@ -54,8 +54,9 @@ func renderPlaywrightMCPConfigWithOptions(yaml *strings.Builder, playwrightTool
 		// Inline format for Copilot
 		yaml.WriteString("                \"args\": [\"run\", \"-i\", \"--rm\", \"--init\", \"" + playwrightImage + "\", \"--output-dir\", \"/tmp/gh-aw/mcp-logs/playwright\"")
 		if len(allowedDomains) > 0 {
-			yaml.WriteString(", \"--allowed-hosts\", \"" + strings.Join(allowedDomains, ";") + "\"")
-			yaml.WriteString(", \"--allowed-origins\", \"" + strings.Join(allowedDomains, ";") + "\"")
+			domainsStr := strings.Join(allowedDomains, ";")
+			yaml.WriteString(", \"--allowed-hosts\", \"" + domainsStr + "\"")
+			yaml.WriteString(", \"--allowed-origins\", \"" + domainsStr + "\"")
 		}
 		// Append custom args if present
 		writeArgsToYAMLInline(yaml, customArgs)
@@ -71,11 +72,12 @@ func renderPlaywrightMCPConfigWithOptions(yaml *strings.Builder, playwrightTool
 		yaml.WriteString("                  \"--output-dir\",\n")
 		yaml.WriteString("                  \"/tmp/gh-aw/mcp-logs/playwright\"")
 		if len(allowedDomains) > 0 {
+			domainsStr := strings.Join(allowedDomains, ";")
 			yaml.WriteString(",\n")
 			yaml.WriteString("                  \"--allowed-hosts\",\n")
-			yaml.WriteString("                  \"" + strings.Join(allowedDomains, ";") + "\",\n")
+			yaml.WriteString("                  \"" + domainsStr + "\",\n")
 			yaml.WriteString("                  \"--allowed-origins\",\n")
-			yaml.WriteString("                  \"" + strings.Join(allowedDomains, ";") + "\"")
+			yaml.WriteString("                  \"" + domainsStr + "\"")
 		}
 		// Append custom args if present
 		writeArgsToYAML(yaml, customArgs, "                  ")
@@ -279,11 +281,12 @@ func renderPlaywrightMCPConfigTOML(yaml *strings.Builder, playwrightTool any) {
 	yaml.WriteString("            \"--output-dir\",\n")
 	yaml.WriteString("            \"/tmp/gh-aw/mcp-logs/playwright\"")
 	if len(args.AllowedDomains) > 0 {
+		domainsStr := strings.Join(args.AllowedDomains, ";")
 		yaml.WriteString(",\n")
 		yaml.WriteString("            \"--allowed-hosts\",\n")
-		yaml.WriteString("            \"" + strings.Join(args.AllowedDomains, ";") + "\",\n")
+		yaml.WriteString("            \"" + domainsStr + "\",\n")
 		yaml.WriteString("            \"--allowed-origins\",\n")
-		yaml.WriteString("            \"" + strings.Join(args.AllowedDomains, ";") + "\"")
+		yaml.WriteString("            \"" + domainsStr + "\"")
 	}
 
 	// Append custom args if present

pkg/workflow/mcp_renderer.go

@@ -132,11 +132,12 @@ func (r *MCPConfigRendererUnified) renderPlaywrightTOML(yaml *strings.Builder, p
 	yaml.WriteString("            \"--output-dir\",\n")
 	yaml.WriteString("            \"/tmp/gh-aw/mcp-logs/playwright\"")
 	if len(args.AllowedDomains) > 0 {
+		domainsStr := strings.Join(args.AllowedDomains, ";")
 		yaml.WriteString(",\n")
 		yaml.WriteString("            \"--allowed-hosts\",\n")
-		yaml.WriteString("            \"" + strings.Join(args.AllowedDomains, ";") + "\",\n")
+		yaml.WriteString("            \"" + domainsStr + "\",\n")
 		yaml.WriteString("            \"--allowed-origins\",\n")
-		yaml.WriteString("            \"" + strings.Join(args.AllowedDomains, ";") + "\"")
+		yaml.WriteString("            \"" + domainsStr + "\"")
 	}
 
 	// Append custom args if present