jsweep: Clean assign_issue, assign_milestone, and assign_to_agent (#7873)

Author: github-actions[bot]

actions/setup/js/assign_issue.cjs

@@ -15,20 +15,20 @@ async function main() {
   const issueNumber = process.env.ISSUE_NUMBER;
 
   // Check if GH_TOKEN is present
-  if (!ghToken || ghToken.trim() === "") {
+  if (!ghToken?.trim()) {
     const docsUrl = "https://githubnext.github.io/gh-aw/reference/safe-outputs/#assigning-issues-to-copilot";
-    core.setFailed(`GH_TOKEN environment variable is required but not set. ` + `This token is needed to assign issues. ` + `For more information on configuring Copilot tokens, see: ${docsUrl}`);
+    core.setFailed(`GH_TOKEN environment variable is required but not set. This token is needed to assign issues. For more information on configuring Copilot tokens, see: ${docsUrl}`);
     return;
   }
 
   // Validate assignee
-  if (!assignee || assignee.trim() === "") {
+  if (!assignee?.trim()) {
     core.setFailed("ASSIGNEE environment variable is required but not set");
     return;
   }
 
   // Validate issue number
-  if (!issueNumber || issueNumber.trim() === "") {
+  if (!issueNumber?.trim()) {
     core.setFailed("ISSUE_NUMBER environment variable is required but not set");
     return;
   }
@@ -39,18 +39,17 @@ async function main() {
 
   core.info(`Assigning issue #${trimmedIssueNumber} to ${trimmedAssignee}`);
 
-  try {
-    // Check if the assignee is a known coding agent (e.g., copilot, @copilot)
-    const agentName = getAgentName(trimmedAssignee);
+  // Check if the assignee is a known coding agent (e.g., copilot, @copilot)
+  const agentName = getAgentName(trimmedAssignee);
 
+  try {
     if (agentName) {
       // Use GraphQL API for agent assignment
       // The token is set at the step level via github-token parameter
       core.info(`Detected coding agent: ${agentName}. Using GraphQL API for assignment.`);
 
       // Get repository owner and repo from context
-      const owner = context.repo.owner;
-      const repo = context.repo.repo;
+      const { owner, repo } = context.repo;
 
       // Find the agent in the repository
       const agentId = await findAgent(owner, repo, agentName);
@@ -86,17 +85,13 @@ async function main() {
     core.info(`✅ Successfully assigned issue #${trimmedIssueNumber} to ${trimmedAssignee}`);
 
     // Write summary
-    await core.summary
-      .addRaw(
-        `
+    await core.summary.addRaw(`
 ## Issue Assignment
 
 Successfully assigned issue #${trimmedIssueNumber} to \`${trimmedAssignee}\`.
-`
-      )
-      .write();
+`).write();
   } catch (error) {
-    const errorMessage = error instanceof Error ? error.message : String(error);
+    const errorMessage = error?.message ?? String(error);
     core.error(`Failed to assign issue: ${errorMessage}`);
     core.setFailed(`Failed to assign issue #${trimmedIssueNumber} to ${trimmedAssignee}: ${errorMessage}`);
   }

actions/setup/js/assign_milestone.cjs

@@ -62,7 +62,7 @@ async function main() {
       allMilestones = milestonesResponse.data;
       core.info(`Fetched ${allMilestones.length} milestones from repository`);
     } catch (error) {
-      const errorMessage = error instanceof Error ? error.message : String(error);
+      const errorMessage = error?.message ?? String(error);
       core.error(`Failed to fetch milestones: ${errorMessage}`);
       core.setFailed(`Failed to fetch milestones for validation: ${errorMessage}`);
       return;
@@ -86,7 +86,7 @@ async function main() {
     }
 
     // Validate against allowed list if configured
-    if (allowedMilestones && allowedMilestones.length > 0) {
+    if (allowedMilestones?.length > 0) {
       const milestone = allMilestones.find(m => m.number === milestoneNumber);
 
       if (!milestone) {
@@ -119,7 +119,7 @@ async function main() {
         success: true,
       });
     } catch (error) {
-      const errorMessage = error instanceof Error ? error.message : String(error);
+      const errorMessage = error?.message ?? String(error);
       core.error(`Failed to assign milestone #${milestoneNumber} to issue #${issueNumber}: ${errorMessage}`);
       results.push({
         issue_number: issueNumber,
@@ -132,23 +132,25 @@ async function main() {
 
   // Generate step summary
   const successCount = results.filter(r => r.success).length;
-  const failureCount = results.filter(r => !r.success).length;
+  const failureCount = results.length - successCount;
 
   let summaryContent = "## Milestone Assignment\n\n";
 
   if (successCount > 0) {
     summaryContent += `✅ Successfully assigned ${successCount} milestone(s):\n\n`;
-    for (const result of results.filter(r => r.success)) {
-      summaryContent += `- Issue #${result.issue_number} → Milestone #${result.milestone_number}\n`;
-    }
-    summaryContent += "\n";
+    summaryContent += results
+      .filter(r => r.success)
+      .map(r => `- Issue #${r.issue_number} → Milestone #${r.milestone_number}`)
+      .join("\n");
+    summaryContent += "\n\n";
   }
 
   if (failureCount > 0) {
     summaryContent += `❌ Failed to assign ${failureCount} milestone(s):\n\n`;
-    for (const result of results.filter(r => !r.success)) {
-      summaryContent += `- Issue #${result.issue_number} → Milestone #${result.milestone_number}: ${result.error}\n`;
-    }
+    summaryContent += results
+      .filter(r => !r.success)
+      .map(r => `- Issue #${r.issue_number} → Milestone #${r.milestone_number}: ${r.error}`)
+      .join("\n");
   }
 
   await core.summary.addRaw(summaryContent).write();

actions/setup/js/assign_to_agent.cjs

@@ -36,7 +36,7 @@ async function main() {
   }
 
   // Get default agent from configuration
-  const defaultAgent = process.env.GH_AW_AGENT_DEFAULT?.trim() || "copilot";
+  const defaultAgent = process.env.GH_AW_AGENT_DEFAULT?.trim() ?? "copilot";
   core.info(`Default agent: ${defaultAgent}`);
 
   // Get max count configuration
@@ -80,7 +80,7 @@ async function main() {
   const results = [];
   for (const item of itemsToProcess) {
     const issueNumber = typeof item.issue_number === "number" ? item.issue_number : parseInt(String(item.issue_number), 10);
-    const agentName = item.agent || defaultAgent;
+    const agentName = item.agent ?? defaultAgent;
 
     if (isNaN(issueNumber) || issueNumber <= 0) {
       core.error(`Invalid issue_number: ${item.issue_number}`);
@@ -148,7 +148,7 @@ async function main() {
         success: true,
       });
     } catch (error) {
-      let errorMessage = error instanceof Error ? error.message : String(error);
+      let errorMessage = error?.message ?? String(error);
       if (errorMessage.includes("coding agent is not available for this repository")) {
         // Enrich with available agent logins to aid troubleshooting - uses built-in github object
         try {
@@ -172,26 +172,28 @@ async function main() {
 
   // Generate step summary
   const successCount = results.filter(r => r.success).length;
-  const failureCount = results.filter(r => !r.success).length;
+  const failureCount = results.length - successCount;
 
   let summaryContent = "## Agent Assignment\n\n";
 
   if (successCount > 0) {
     summaryContent += `✅ Successfully assigned ${successCount} agent(s):\n\n`;
-    for (const result of results.filter(r => r.success)) {
-      summaryContent += `- Issue #${result.issue_number} → Agent: ${result.agent}\n`;
-    }
-    summaryContent += "\n";
+    summaryContent += results
+      .filter(r => r.success)
+      .map(r => `- Issue #${r.issue_number} → Agent: ${r.agent}`)
+      .join("\n");
+    summaryContent += "\n\n";
   }
 
   if (failureCount > 0) {
     summaryContent += `❌ Failed to assign ${failureCount} agent(s):\n\n`;
-    for (const result of results.filter(r => !r.success)) {
-      summaryContent += `- Issue #${result.issue_number} → Agent: ${result.agent}: ${result.error}\n`;
-    }
+    summaryContent += results
+      .filter(r => !r.success)
+      .map(r => `- Issue #${r.issue_number} → Agent: ${r.agent}: ${r.error}`)
+      .join("\n");
 
     // Check if any failures were permission-related
-    const hasPermissionError = results.some(r => !r.success && r.error && (r.error.includes("Resource not accessible") || r.error.includes("Insufficient permissions")));
+    const hasPermissionError = results.some(r => !r.success && r.error?.includes("Resource not accessible") || r.error?.includes("Insufficient permissions"));
 
     if (hasPermissionError) {
       summaryContent += generatePermissionErrorSummary();