Add validation for workflow intent minimum content requirements (#7852)

Author: Copilot

pkg/cli/interactive.go

@@ -213,7 +213,8 @@ func (b *InteractiveWorkflowBuilder) promptForConfiguration() error {
 		huh.NewGroup(
 			huh.NewText().
 				Title("Describe what this workflow should do:").
-				Value(&b.Intent),
+				Value(&b.Intent).
+				Validate(ValidateWorkflowIntent),
 		).
 			Title("Instructions").
 			Description("Describe what you want this workflow to accomplish"),

pkg/cli/validators.go

@@ -3,6 +3,7 @@ package cli
 import (
 	"errors"
 	"regexp"
+	"strings"
 )
 
 // workflowNameRegex validates workflow names contain only alphanumeric characters, hyphens, and underscores
@@ -19,3 +20,17 @@ func ValidateWorkflowName(s string) error {
 	}
 	return nil
 }
+
+// ValidateWorkflowIntent checks if the provided workflow intent is valid.
+// It ensures the intent has meaningful content with at least 20 characters
+// and is not just whitespace.
+func ValidateWorkflowIntent(s string) error {
+	trimmed := strings.TrimSpace(s)
+	if len(trimmed) == 0 {
+		return errors.New("workflow instructions cannot be empty")
+	}
+	if len(trimmed) < 20 {
+		return errors.New("please provide at least 20 characters of instructions")
+	}
+	return nil
+}

pkg/cli/validators_test.go

@@ -245,3 +245,170 @@ func TestValidateWorkflowName_EdgeCases(t *testing.T) {
 		})
 	}
 }
+
+func TestValidateWorkflowIntent(t *testing.T) {
+	tests := []struct {
+		name        string
+		input       string
+		expectError bool
+		errorMsg    string
+	}{
+		{
+			name:        "valid minimal intent",
+			input:       "Create a workflow to triage issues",
+			expectError: false,
+		},
+		{
+			name:        "valid long intent",
+			input:       "Create a comprehensive workflow that automatically triages GitHub issues by analyzing their content, assigning appropriate labels, and notifying relevant team members",
+			expectError: false,
+		},
+		{
+			name:        "valid exactly 20 characters",
+			input:       "12345678901234567890",
+			expectError: false,
+		},
+		{
+			name:        "valid with newlines",
+			input:       "Create a workflow to\ntriage issues automatically",
+			expectError: false,
+		},
+		{
+			name:        "valid with leading/trailing whitespace",
+			input:       "  Create a workflow to triage issues  ",
+			expectError: false,
+		},
+		{
+			name:        "empty string",
+			input:       "",
+			expectError: true,
+			errorMsg:    "workflow instructions cannot be empty",
+		},
+		{
+			name:        "only whitespace",
+			input:       "   \t\n  ",
+			expectError: true,
+			errorMsg:    "workflow instructions cannot be empty",
+		},
+		{
+			name:        "only spaces",
+			input:       "     ",
+			expectError: true,
+			errorMsg:    "workflow instructions cannot be empty",
+		},
+		{
+			name:        "only tabs",
+			input:       "\t\t\t",
+			expectError: true,
+			errorMsg:    "workflow instructions cannot be empty",
+		},
+		{
+			name:        "only newlines",
+			input:       "\n\n\n",
+			expectError: true,
+			errorMsg:    "workflow instructions cannot be empty",
+		},
+		{
+			name:        "too short - single character",
+			input:       "a",
+			expectError: true,
+			errorMsg:    "please provide at least 20 characters of instructions",
+		},
+		{
+			name:        "too short - 5 characters",
+			input:       "hello",
+			expectError: true,
+			errorMsg:    "please provide at least 20 characters of instructions",
+		},
+		{
+			name:        "too short - 19 characters",
+			input:       "1234567890123456789",
+			expectError: true,
+			errorMsg:    "please provide at least 20 characters of instructions",
+		},
+		{
+			name:        "too short with whitespace padding",
+			input:       "   test   ",
+			expectError: true,
+			errorMsg:    "please provide at least 20 characters of instructions",
+		},
+		{
+			name:        "19 chars after trim",
+			input:       "   1234567890123456789   ",
+			expectError: true,
+			errorMsg:    "please provide at least 20 characters of instructions",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			err := ValidateWorkflowIntent(tt.input)
+
+			if tt.expectError {
+				if err == nil {
+					t.Errorf("ValidateWorkflowIntent(%q) expected error but got nil", tt.input)
+					return
+				}
+				if !strings.Contains(err.Error(), tt.errorMsg) {
+					t.Errorf("ValidateWorkflowIntent(%q) error = %q, want error containing %q", tt.input, err.Error(), tt.errorMsg)
+				}
+			} else {
+				if err != nil {
+					t.Errorf("ValidateWorkflowIntent(%q) unexpected error: %v", tt.input, err)
+				}
+			}
+		})
+	}
+}
+
+func TestValidateWorkflowIntent_EdgeCases(t *testing.T) {
+	tests := []struct {
+		name        string
+		input       string
+		expectError bool
+	}{
+		{
+			name:        "exactly 20 characters with spaces",
+			input:       "a b c d e f g h i j k",
+			expectError: false,
+		},
+		{
+			name:        "unicode characters",
+			input:       "Create workflow with émojis 🎉🎊",
+			expectError: false,
+		},
+		{
+			name:        "special characters",
+			input:       "Create workflow: @user, #123, $var!",
+			expectError: false,
+		},
+		{
+			name:        "very long intent",
+			input:       strings.Repeat("a", 1000),
+			expectError: false,
+		},
+		{
+			name:        "mixed whitespace",
+			input:       "  \t\n  Create workflow for automation  \t\n  ",
+			expectError: false,
+		},
+		{
+			name:        "only punctuation but >= 20 chars",
+			input:       "!@#$%^&*()_+-={}[]|;",
+			expectError: false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			err := ValidateWorkflowIntent(tt.input)
+
+			if tt.expectError && err == nil {
+				t.Errorf("ValidateWorkflowIntent(%q) expected error but got nil", tt.input)
+			}
+			if !tt.expectError && err != nil {
+				t.Errorf("ValidateWorkflowIntent(%q) unexpected error: %v", tt.input, err)
+			}
+		})
+	}
+}