Commit 9d4e2ba
fix(shared/apm.md): drop || 'all' fallback so gh-aw substitutes target (#1185) (#1186)
The bare-expression regex in gh-aw's importInputsExprRegex
(pkg/parser/import_field_extractor.go) only matches
`${{ github.aw.import-inputs.X }}`. The `|| 'all'` belt-and-suspenders
introduced in #1184 made the regex skip substitution entirely, so
consumer-supplied `with: target: copilot` was silently ignored: the
unresolved expression survived into the lock workflow and the runtime
env was empty (which apm-action then treated as `all`).
The schema default `default: all` declared in import-schema is already
applied by gh-aw's applyImportSchemaDefaultsFromFrontmatter BEFORE
substitution, so the fallback was redundant. Dropping it lets gh-aw
substitute literal values into consuming lock workflows.
Recompiled with gh-aw v0.71.5 (matching the version stamped in lock
metadata). The two consuming lock workflows now carry the literal
substituted value `target: all` since neither import sets `target:`.
Consumers who pass `with: target: copilot` will get `target: copilot`.
Closes #1185.
Co-authored-by: Daniel Meppiel <copilot-rework@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent b3fa147 commit 9d4e2ba
4 files changed
Lines changed: 7 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
287 | 287 | | |
288 | 288 | | |
289 | 289 | | |
290 | | - | |
| 290 | + | |
291 | 291 | | |
292 | 292 | | |
293 | 293 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
14 | 18 | | |
15 | 19 | | |
16 | 20 | | |
| |||
0 commit comments