Skip to content

Commit 9d4e2ba

Browse files
danielmeppielDaniel MeppielCopilot
authored
fix(shared/apm.md): drop || 'all' fallback so gh-aw substitutes target (#1185) (#1186)
The bare-expression regex in gh-aw's importInputsExprRegex (pkg/parser/import_field_extractor.go) only matches `${{ github.aw.import-inputs.X }}`. The `|| 'all'` belt-and-suspenders introduced in #1184 made the regex skip substitution entirely, so consumer-supplied `with: target: copilot` was silently ignored: the unresolved expression survived into the lock workflow and the runtime env was empty (which apm-action then treated as `all`). The schema default `default: all` declared in import-schema is already applied by gh-aw's applyImportSchemaDefaultsFromFrontmatter BEFORE substitution, so the fallback was redundant. Dropping it lets gh-aw substitute literal values into consuming lock workflows. Recompiled with gh-aw v0.71.5 (matching the version stamped in lock metadata). The two consuming lock workflows now carry the literal substituted value `target: all` since neither import sets `target:`. Consumers who pass `with: target: copilot` will get `target: copilot`. Closes #1185. Co-authored-by: Daniel Meppiel <copilot-rework@github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent b3fa147 commit 9d4e2ba

4 files changed

Lines changed: 7 additions & 3 deletions

File tree

.github/workflows/pr-review-panel.lock.yml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/shared/apm.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ jobs:
287287
isolated: 'true'
288288
pack: 'true'
289289
archive: 'true'
290-
target: ${{ github.aw.import-inputs.target || 'all' }}
290+
target: ${{ github.aw.import-inputs.target }}
291291
working-directory: /tmp/gh-aw/apm-workspace
292292
- name: Upload APM bundle artifact
293293
if: success()

.github/workflows/triage-panel.lock.yml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1111

1212
- `shared/apm.md` gh-aw shared workflow exposes a `target:` import input (default `all`) so consumer workflows can ship slim, single-harness bundles instead of always packing every layout. (#1184)
1313

14+
### Fixed
15+
16+
- `shared/apm.md` no longer wraps the `target` input in a `|| 'all'` fallback. The defensive expression broke gh-aw's bare-expression substitution regex, causing consumer-supplied `target:` values to be silently dropped; the `import-schema` default already covers the omitted-input case. (#1185)
17+
1418
## [0.12.4] - 2026-05-07
1519

1620
### Fixed

0 commit comments

Comments
 (0)