test: add coverage for Python/Node runtimes and upload-pipeline-artifact#461
Merged
jamesadevine merged 3 commits intomainfrom May 8, 2026
Merged
Conversation
…, fix Node display_name Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/fe597b1f-5968-4257-8d4c-1b63e8dfc7e4 Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add tests for Python and Node runtime gaps
test: add coverage for Python/Node runtimes and upload-pipeline-artifact
May 8, 2026
Collaborator
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Contributor
Author
Resolved the merge conflicts in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes test gaps in the Python/Node runtimes and
upload-pipeline-artifact: zero unit tests on the YAML generators, no integration coverage forruntimes: python|node, notools/listassertion forupload-pipeline-artifact, and noexecutedispatch test for it.generate_python_install(default + pinned),generate_pip_authenticate,generate_node_install(default + pinned),generate_npm_authenticate,generate_ensure_npmrc(default registry fallback + customfeed-urlbranch).runtimes: python: true,runtimes: python: { version: "3.12" }, andruntimes: node: trueend-to-end via theado-awbinary, asserting the expectedUsePythonVersion@0/NodeTool@0task andversionSpec.tools/list— assertupload-pipeline-artifactis registered.test_execute_malformed_upload_pipeline_artifact_returns_errmirrors the existing wiki/upload patterns and exercises thedispatch_resource_toolsarm.NodeExtension::name()returned"Node.js", whose.is rejected by thewrap_prompt_appenddisplay_name sanitizer, so any pipeline withruntimes: nodefailed to compile. Renamed to"Node"and updated the three pre-existing extension tests pinning the string. The Node runtime had no compile-level test, which is why this slipped through — exactly the gap this PR closes.maininto the branch and resolved a conflict intests/compiler_tests.rs, preserving both the new dotnet runtime integration tests landed onmainand the new Python/Node runtime integration tests added by this PR.Summary
Adds 7 unit tests, 3 compile-level integration tests, and a missing MCP
tools/listassertion to cover the Python/Node runtimes and theupload-pipeline-artifactsafe output. The new Node integration test surfaced and is fixed alongside a regression whereNodeExtension::name()("Node.js") violated the display_name sanitizer, breaking Node runtime compilation. Also resolves a merge conflict withmainso both the new dotnet runtime tests and the new Python/Node runtime tests coexist intests/compiler_tests.rs.Test plan
cargo test --bin ado-aw— 1234 passed (was 1227, +7).cargo test --test compiler_tests -- test_python_runtime test_node_runtime test_dotnet_runtime test_lean_runtime— all 6 runtime integration tests pass after the merge resolution.cargo test --test compiler_tests -- test_python_runtime test_node_runtime— 3 new tests pass; without theNode.js→Nodefix,test_node_runtime_compiled_outputfails with the sanitizer error, confirming the test catches the regression.cargo test --test mcp_http_tests test_mcp_initialize_and_tools_list— passes with the new assertion.cargo clippy --all-targets --all-features— no new warnings.