remove unused code, move deprecated tool aliases to its own file

Author: tommaso-moro

pkg/github/deprecated_tool_aliases.go

@@ -0,0 +1,14 @@
+// tool_aliases.go
+package github
+
+// DeprecatedToolAliases maps old tool names to their new canonical names.
+// When tools are renamed, add an entry here to maintain backward compatibility.
+// Users referencing the old name will receive the new tool with a deprecation warning.
+//
+// Example:
+//
+//	"get_issue": "issue_read",
+//	"create_pr": "pull_request_create",
+var DeprecatedToolAliases = map[string]string{
+	// Add entries as tools are renamed
+}

pkg/github/tools.go

@@ -160,12 +160,6 @@ func GetDefaultToolsetIDs() []string {
 	}
 }
 
-// DeprecatedToolAliases maps old tool names to their new canonical names.
-// This allows tool renames without breaking existing user configurations.
-// When a user requests an old tool name, it will silently resolve to the new name.
-// Example: "get_issue" : "issue_read"
-var DeprecatedToolAliases = map[string]string{}
-
 func DefaultToolsetGroup(readOnly bool, getClient GetClientFn, getGQLClient GetGQLClientFn, getRawClient raw.GetRawClientFn, t translations.TranslationHelperFunc, contentWindowSize int, flags FeatureFlags, cache *lockdown.RepoAccessCache) *toolsets.ToolsetGroup {
 	tsg := toolsets.NewToolsetGroup(readOnly)
 

pkg/toolsets/toolsets.go

@@ -326,14 +326,6 @@ func NewToolDoesNotExistError(name string) *ToolDoesNotExistError {
 	return &ToolDoesNotExistError{Name: name}
 }
 
-// ToolLookupResult contains the result of a tool lookup operation.
-type ToolLookupResult struct {
-	Tool          *ServerTool
-	ToolsetName   string
-	RequestedName string // The name that was requested (may differ from Tool.Name if alias was used)
-	AliasUsed     bool   // True if the requested name was a deprecated alias
-}
-
 // FindToolByName searches all toolsets (enabled or disabled) for a tool by name.
 // It resolves deprecated aliases automatically and logs a warning when an alias is used.
 // Returns the tool, its parent toolset name, and an error if not found.
@@ -361,32 +353,6 @@ func (tg *ToolsetGroup) FindToolByName(toolName string) (*ServerTool, string, er
 	return nil, "", NewToolDoesNotExistError(toolName)
 }
 
-// FindToolWithAliasInfo searches all toolsets for a tool by name and returns
-// additional metadata about whether a deprecated alias was used.
-// Use this when you need to track/log deprecated alias usage (e.g., for telemetry).
-func (tg *ToolsetGroup) FindToolWithAliasInfo(toolName string) (*ToolLookupResult, error) {
-	requestedName := toolName
-	aliasUsed := false
-
-	// Check if this is a deprecated alias and resolve to canonical name
-	if canonicalName, isAlias := tg.deprecatedAliases[toolName]; isAlias {
-		toolName = canonicalName
-		aliasUsed = true
-	}
-
-	tool, toolsetName, err := tg.FindToolByName(toolName)
-	if err != nil {
-		return nil, NewToolDoesNotExistError(requestedName)
-	}
-
-	return &ToolLookupResult{
-		Tool:          tool,
-		ToolsetName:   toolsetName,
-		RequestedName: requestedName,
-		AliasUsed:     aliasUsed,
-	}, nil
-}
-
 // RegisterSpecificTools registers only the specified tools.
 // Respects read-only mode (skips write tools if readOnly=true).
 // Returns error if any tool is not found.