lint and bug fixes for actions get logs tools

Author: mattdholloway

README.md

@@ -431,13 +431,18 @@ The following sets of tools are available:
 
 - **actions_get** - Get details of GitHub Actions resources (workflows, workflow runs, jobs, and artifacts)
   - `action`: The action to perform (string, required)
+  - `failed_only`: When true, gets logs for all failed jobs in the workflow run specified by resource_id (only for 'get_job_logs' action) (boolean, optional)
+  - `job_id`: The unique identifier of the workflow job (required for single job logs when action is 'get_job_logs') (number, optional)
   - `owner`: Repository owner (string, required)
   - `repo`: Repository name (string, required)
   - `resource_id`: The unique identifier of the resource. This will vary based on the "action" provided, so ensure you provide the correct ID:
 - Provide a workflow ID or workflow file name (e.g. ci.yaml) for 'get_workflow' action.
-- Provide a workflow run ID for 'get_workflow_run', 'download_workflow_run_artifact' and 'get_workflow_run_usage' actions.
+- Provide a workflow run ID for 'get_workflow_run', 'download_workflow_run_artifact', 'get_workflow_run_usage', and 'get_workflow_run_logs' actions.
 - Provide a job ID for the 'get_workflow_job' action.
- (string, required)
+- Provide a workflow run ID for 'get_job_logs' action when using failed_only parameter.
+ (string, optional)
+  - `return_content`: Returns actual log content instead of URLs (only for 'get_job_logs' action) (boolean, optional)
+  - `tail_lines`: Number of lines to return from the end of the log (only for 'get_job_logs' action) (number, optional)
 
 - **actions_list** - List GitHub Actions workflows in a repository
   - `action`: The action to perform (string, required)
@@ -464,20 +469,6 @@ The following sets of tools are available:
   - `repo`: Repository name (string, required)
   - `run_id`: The unique identifier of the workflow run (number, required)
 
-- **get_job_logs** - Get job logs
-  - `failed_only`: When true, gets logs for all failed jobs in run_id (boolean, optional)
-  - `job_id`: The unique identifier of the workflow job (required for single job logs) (number, optional)
-  - `owner`: Repository owner (string, required)
-  - `repo`: Repository name (string, required)
-  - `return_content`: Returns actual log content instead of URLs (boolean, optional)
-  - `run_id`: Workflow run ID (required when using failed_only) (number, optional)
-  - `tail_lines`: Number of lines to return from the end of the log (number, optional)
-
-- **get_workflow_run_logs** - Get workflow run logs
-  - `owner`: Repository owner (string, required)
-  - `repo`: Repository name (string, required)
-  - `run_id`: The unique identifier of the workflow run (number, required)
-
 - **run_workflow** - Run workflow
   - `inputs`: Inputs the workflow accepts (object, optional)
   - `owner`: Repository owner (string, required)

pkg/github/actions.go

@@ -78,7 +78,7 @@ func actionFromString(s string) actionsActionType {
 	return actionsActionTypeUnknown
 }
 
-func ActionsList(getClient GetClientFn, t translations.TranslationHelperFunc, contentWindowSize int) (tool mcp.Tool, handler server.ToolHandlerFunc) {
+func ActionsList(getClient GetClientFn, t translations.TranslationHelperFunc, _ int) (tool mcp.Tool, handler server.ToolHandlerFunc) {
 	return mcp.NewTool("actions_list",
 			mcp.WithDescription(t("TOOL_ACTIONS_LIST_DESCRIPTION", `Tools for listing GitHub Actions resources.
 Use this tool to list workflows in a repository, or list workflow runs, jobs, and artifacts for a specific workflow or workflow run.
@@ -289,8 +289,8 @@ Use this tool to get details about individual workflows, workflow runs, jobs, an
 - Provide a workflow run ID for 'get_job_logs' action when using failed_only parameter.
 `),
 			),
-			mcp.WithBoolean("job_id",
-				mcp.Description("The ID of the job to get logs for (only for 'get_job_logs' action)"),
+			mcp.WithNumber("job_id",
+				mcp.Description("The unique identifier of the workflow job (required for single job logs when action is 'get_job_logs')"),
 			),
 			mcp.WithBoolean("failed_only",
 				mcp.Description("When true, gets logs for all failed jobs in the workflow run specified by resource_id (only for 'get_job_logs' action)"),
@@ -336,7 +336,7 @@ Use this tool to get details about individual workflows, workflow runs, jobs, an
 			}
 
 			// Get optional parameters for get_job_logs
-			jobID, err := OptionalParam[int64](request, "job_id")
+			jobID, err := OptionalIntParam(request, "job_id")
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
 			}
@@ -351,7 +351,7 @@ Use this tool to get details about individual workflows, workflow runs, jobs, an
 				return mcp.NewToolResultError(err.Error()), nil
 			}
 
-			tailLines, err := OptionalParam[int](request, "tail_lines")
+			tailLines, err := OptionalIntParam(request, "tail_lines")
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
 			}
@@ -394,7 +394,7 @@ Use this tool to get details about individual workflows, workflow runs, jobs, an
 			case actionsActionTypeGetWorkflowRunLogs:
 				return getWorkflowRunLogs(ctx, client, request, owner, repo, resourceIDInt)
 			case actionsActionTypeGetWorkflowJobLogs:
-				return getWorkflowJobLogs(ctx, client, request, owner, repo, resourceIDInt, jobID, returnContent, failedOnly, tailLines, contentWindowSize)
+				return getWorkflowJobLogs(ctx, client, request, owner, repo, resourceIDInt, int64(jobID), returnContent, failedOnly, tailLines, contentWindowSize)
 			case actionsActionTypeUnknown:
 				return mcp.NewToolResultError(fmt.Sprintf("unknown action: %s", actionTypeStr)), nil
 			default:
@@ -810,7 +810,7 @@ func getWorkflowRunLogs(ctx context.Context, client *github.Client, _ mcp.CallTo
 }
 
 // getWorkflowJobLogs downloads logs for a specific workflow job or efficiently gets all failed job logs for a workflow run
-func getWorkflowJobLogs(ctx context.Context, client *github.Client, request mcp.CallToolRequest, owner, repo string, runID int64, jobID int64, returnContent bool, failedOnly bool, tailLines int, contentWindowSize int) (*mcp.CallToolResult, error) {
+func getWorkflowJobLogs(ctx context.Context, client *github.Client, _ mcp.CallToolRequest, owner, repo string, runID int64, jobID int64, returnContent bool, failedOnly bool, tailLines int, contentWindowSize int) (*mcp.CallToolResult, error) {
 	// Default to 500 lines if not specified
 	if tailLines == 0 {
 		tailLines = 500

pkg/github/actions_test.go

@@ -783,12 +783,14 @@ func Test_GetJobLogs(t *testing.T) {
 
 	assert.Equal(t, "actions_get", tool.Name)
 	assert.NotEmpty(t, tool.Description)
+	assert.Contains(t, tool.InputSchema.Properties, "action")
 	assert.Contains(t, tool.InputSchema.Properties, "owner")
 	assert.Contains(t, tool.InputSchema.Properties, "repo")
+	assert.Contains(t, tool.InputSchema.Properties, "resource_id")
 	assert.Contains(t, tool.InputSchema.Properties, "job_id")
-	assert.Contains(t, tool.InputSchema.Properties, "run_id")
 	assert.Contains(t, tool.InputSchema.Properties, "failed_only")
 	assert.Contains(t, tool.InputSchema.Properties, "return_content")
+	assert.Contains(t, tool.InputSchema.Properties, "tail_lines")
 	assert.ElementsMatch(t, tool.InputSchema.Required, []string{"action", "owner", "repo"})
 
 	tests := []struct {
@@ -1307,7 +1309,7 @@ func Test_ActionsGet(t *testing.T) {
 	assert.Contains(t, tool.InputSchema.Properties, "owner")
 	assert.Contains(t, tool.InputSchema.Properties, "repo")
 	assert.Contains(t, tool.InputSchema.Properties, "resource_id")
-	assert.ElementsMatch(t, tool.InputSchema.Required, []string{"action", "owner", "repo", "resource_id"})
+	assert.ElementsMatch(t, tool.InputSchema.Required, []string{"action", "owner", "repo"})
 
 	tests := []struct {
 		name           string
@@ -1320,7 +1322,6 @@ func Test_ActionsGet(t *testing.T) {
 			name:         "missing required parameter action",
 			mockedClient: mock.NewMockedHTTPClient(),
 			requestArgs: map[string]any{
-				"action":      actionsActionTypeGetWorkflowJobLogs.String(),
 				"owner":       "owner",
 				"repo":        "repo",
 				"resource_id": "123",
@@ -2112,7 +2113,7 @@ func Test_ActionsResourceRead_GetWorkflowUsage(t *testing.T) {
 									TotalMS: github.Ptr(int64(60000)),
 									Jobs:    github.Ptr(1),
 									JobRuns: []*github.WorkflowRunJobRun{
-										&github.WorkflowRunJobRun{
+										{
 											JobID:      github.Ptr(1),
 											DurationMS: github.Ptr(int64(600)),
 										},