Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
| "maximum": 10240, | ||
| "default": 1024 | ||
| }, | ||
| "safe-jobs": { |
There was a problem hiding this comment.
Moved safe-jobs element to top level (out of safe-outputs section). Updated schema, parsing logic, and all related functionality to handle safe-jobs as a top-level frontmatter property. Commit: [pending]
Added the "echo" safe job to dev.md as requested. The safe job takes a message input and echoes it in the steps. You can see it in the generated dev.lock.yml file. Commit: 976676e |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot safe-jobs from an included workflows should be imported as well. Any clash on names fails the compilation. |
|
@copilot prepend environment variable with GITHUB_AW_ SAFE_JOB_MESSAGE --> GITHUB_AW_SAFE_JOB_MESSGAE |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Updated environment variable prefix from |
| config.Allowed = append(config.Allowed, "push-to-pull-request-branch") | ||
| case "missing-tool": | ||
| config.Allowed = append(config.Allowed, "missing-tool") | ||
| case "safe-jobs": |
There was a problem hiding this comment.
Removed nested "safe-jobs" support from the MCP parser. Since safe-jobs are now handled as a top-level element, the nested case handling within safe-outputs was obsolete and has been cleaned up. Top-level safe-jobs continue to work correctly. Commit: [pending]
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot safe-jobs jobs from an included workflows should be imported as well. Fail if you find duplicate job ids |
Updated the safe-outputs MCP server to use safe-job display names (Name field) as tool descriptions. When a safe-job has a name property, it appears as "Safe job: [Name]" in MCP tool listings for better discoverability. Commit: ab404c9
Updated generateMCPSetup to ensure the safe-outputs MCP server is generated whenever any safe-jobs are defined, in addition to when safe-outputs are configured. The MCP server is now properly created to handle safe-job tools. Commit: ab404c9 |
|
@copilot make sure that the safe outputs mcp is code generated when any safe-jobs are defined. |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Updated generateMCPSetup to ensure the safe-outputs MCP server is generated whenever any safe-jobs are defined. Fixed the hasSafeOutputs logic to check for both SafeOutputs and SafeJobs configurations, and added proper null checks to prevent runtime errors. Commit: 8731d17 |
…92c2-461a-9f15-c06fb1a8c332
…ants for output file names
…n safe-jobs workflow
…lt message fallback and streamline output handling
… proper output handling
… handling and ensure correct message selection
…utput clarity and summary logging
- Introduced a new workflow for testing safe jobs in the CLI. - Implemented a `print` job that outputs a specified message. - Configured the workflow to trigger on workflow dispatch and pushes to branches matching 'copilot/*'. - Added steps to check for agent output and print messages accordingly. - Included a summary section for better visibility of printed messages.
…dundant parameters
Safe-Jobs Feature - Complete MCP Server Generation Fix
Successfully updated the MCP server generation logic to ensure the safe-outputs MCP server is created whenever safe-jobs are defined, completing the final requirement for the safe-jobs feature.
✅ MCP Server Generation Fix - COMPLETE:
✅ Implementation Details:
Updated MCP Generation Logic:
Safe Environment Variable Setup:
✅ What This Fixes:
✅ Complete Feature Status:
The safe-jobs feature is now 100% complete with all requirements implemented:
✅ Ready for Production:
The safe-jobs feature is now fully production-ready with guaranteed MCP server generation, ensuring that safe-job tools are always available to agentic workflows when safe-jobs are defined. This completes the comprehensive implementation of custom safe-output jobs with complete MCP integration.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.