[cache-strategy] Fix cache miss in Matt Pocock Skills Reviewer

[github-actions]

Cache Strategy Problem: Matt Pocock Skills Reviewer

Severity: Medium

Workflow: Matt Pocock Skills Reviewer
Analysis Date: 2026-05-09
Issue Type: Cache miss / No persisted cache contents

---

Problem Description

The workflow declared cache-memory and used a valid last-write-wins key pattern with a restore-key fallback, but three runs in the last 24 hours all cold-started. In each run, the agent was instructed to read /tmp/gh-aw/cache-memory/pr-31224.json, then the cache upload step reported that no files existed under /tmp/gh-aw/cache-memory, so the next run had nothing to restore.

Evidence

• Miss streak: 3 consecutive observed runs
• Miss rate (available 24h baseline): 100% for this workflow
• Last cache hit: never observed in the available cache-strategy history
• Log signals: Cache not found for input keys: memory-approved-6f25a3c0-mattpocockskillsreviewer-<run_id>, memory-approved-6f25a3c0-mattpocockskillsreviewer-
• No persisted files: No files were found with the provided path: /tmp/gh-aw/cache-memory. No artifacts will be uploaded.

Observed Runs

Run	Signal
§25605065311	cache miss, no cache-memory files uploaded
§25606633628	cache miss, no cache-memory files uploaded
§25607131268	cache miss, no cache-memory files uploaded

Recommended Fix

1. Persist the review state after reading it — When the workflow reads /tmp/gh-aw/cache-memory/pr-<number>.json, ensure it writes an updated JSON file before completion.
2. Keep the current restore-key fallback — The key includes the run ID, but the restore-key prefix is present and valid for the last-write-wins pattern.
3. Add a simple write verification — Before the agent exits, check that at least one expected cache file exists under /tmp/gh-aw/cache-memory so the upload step has useful state to persist.

Expected Impact

Fixing this should let repeated reviews of the same PR reuse prior notes instead of re-reading an empty cache and redoing review-context work on every run.

References: §25605065311, §25606633628, §25607131268

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

• api.github.com
• github.com

💡 Tip: api.github.com is blocked because GitHub API access uses the built-in GitHub tools by default. Instead of adding api.github.com to network.allowed, use tools.github.mode: gh-proxy for direct pre-authenticated GitHub CLI access without requiring network access to api.github.com:

tools:
  github:
    mode: gh-proxy

See GitHub Tools for more information on gh-proxy mode.

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.github.com"
    - "github.com"

See Network Configuration for more information.

Generated by Daily Cache Strategy Analyzer · ◷

• expires on May 16, 2026, 6:49 PM UTC