[repository-quality] Large File Refactoring & Maintainability — Reuse Analysis (2026-06-05)

[github-actions[bot]]

🎯 Repository Quality Improvement Report — Large File Refactoring & Maintainability

Analysis Date: 2026-06-05 | Strategy Type: Reuse (random=91, 10% tier) | Custom Area: No

Executive Summary

Original analysis: 2026-05-20. This reuse run confirms zero refactoring progress: 35 source files still exceed 800 lines (up from 28 in May), with the top file at 1866 lines. The largest contributors remain in pkg/workflow/ and pkg/parser/.

Each oversized file bundles distinct logical concerns, inflating review surface and complicating unit testing. The handler registry alone in safe_outputs_config.go is 924 lines and can be split with zero API changes. Five concrete split tasks are provided below — all are within-package moves requiring no import changes.

Full Analysis Report

Current State Assessment

Metric	Value	Status
Source files > 800 lines	35	❌
Source files > 1000 lines	14	❌
Largest file (safe_outputs_config.go)	1866 lines	❌
Progress since 2026-05-20	0 files reduced	❌
Test-to-source LOC ratio	429 478 : 212 694	✅
TODO/FIXME count	17	✅

Top 10 oversized files:

File	Lines	Concerns
pkg/workflow/safe_outputs_config.go	1866	config extraction + 924-line handler registry
pkg/parser/remote_fetch.go	1342	file download + symlink resolution + SHA resolution
pkg/parser/import_field_extractor.go	1308	core extraction + activation + step/job + feature fields
pkg/workflow/frontmatter_extraction_yaml.go	1189	many independent field extractors
pkg/workflow/compiler_jobs.go	1178	job builder + custom jobs + memory management
pkg/cli/audit.go	1170	audit command + diff + rendering
pkg/workflow/compiler_yaml_main_job.go	1077	main job build + step generation
pkg/workflow/cache.go	1074	cache keys + restore/save steps + hashing
pkg/workflow/compiler_yaml.go	1071	YAML generation + 300-line prompt generator
pkg/cli/logs_orchestrator.go	1063	log fetching + formatting + streaming

Findings

Strengths

• Consistent package grouping makes within-package splits trivially safe — no import changes needed.
• Files already use internal cohesion markers (logger names, comment headers) as natural split points.
• Test files are named per-source-file, so test co-location requires no restructuring.

Areas for Improvement

• safe_outputs_config.go lines 781–1704 (~924 lines): the handlerRegistry map literal is the single largest contiguous block in the codebase.
• remote_fetch.go lines 699–823 (~125 lines): symlink group (checkRemoteSymlink, resolveRemoteSymlinks, family) is fully self-contained.
• domains.go lines 26–236 (~210 lines): per-engine domain var declarations are pure data before any function definitions.
• compiler_yaml.go lines 463–757 (~295 lines): generatePrompt and five helpers have no dependency on surrounding YAML generation.
• import_field_extractor.go lines 419–529 (~110 lines): contiguous activation-field extraction group.

---

🤖 Tasks for Copilot Agent

NOTE TO PLANNER AGENT: Split the following tasks into individual work items.

Task 1: Extract handler registry from safe_outputs_config.go

Priority: High | Effort: Small | Region: pkg/workflow/safe_outputs_config.go lines 781–1704

Description: Move handlerRegistry var, handlerBuilder type, and all handler builder closures (~924 lines) into a new file pkg/workflow/safe_outputs_handlers.go (package workflow). Also move buildMentionsHandlerConfig if only referenced by the registry. Pure move, no signature changes.

Acceptance Criteria:

• safe_outputs_handlers.go created with package workflow
• safe_outputs_config.go drops below 950 lines
• go build ./... and go test ./pkg/workflow/... pass
• No public API changed

---

Task 2: Split remote_fetch.go — extract symlink resolution

Priority: High | Effort: Small | Region: pkg/parser/remote_fetch.go lines 699–823

Description: Move checkRemoteSymlink, resolveRemoteSymlinks, resolveRemoteSymlinkComponent, resolveAndValidateRemoteSymlinkBase into pkg/parser/remote_symlinks.go. Preserve the //go:build !js && !wasm constraint. remoteLog stays in remote_fetch.go and is accessible package-wide.

Acceptance Criteria:

• remote_symlinks.go created with package parser and correct build tag
• remote_fetch.go drops below 1220 lines
• go build ./... and go test ./pkg/parser/... pass

---

Task 3: Split domains.go — extract engine-specific domain declarations

Priority: Medium | Effort: Small | Region: pkg/workflow/domains.go lines 26–236

Description: Move all per-engine var declarations (CopilotDefaultDomains, CodexDefaultDomains, ClaudeDefaultDomains, AntigravityDefaultDomains, GeminiDefaultDomains, Pi/Crush/OpenCode variants, provider maps) into pkg/workflow/domains_engine_defaults.go. The init() function and all lookup functions stay in domains.go.

Acceptance Criteria:

• domains_engine_defaults.go created with package workflow
• domains.go drops below 850 lines
• go build ./... and go test ./pkg/workflow/... pass

---

Task 4: Split compiler_yaml.go — extract prompt generation

Priority: Medium | Effort: Small | Region: pkg/workflow/compiler_yaml.go lines 463–800

Description: Extract generatePrompt and its five helpers (writePromptBashStep, generatePreSteps, generatePostSteps, generatePreAgentSteps, writeStepsSection) into pkg/workflow/compiler_yaml_prompt.go. All are *Compiler methods or package helpers; no import changes needed.

Acceptance Criteria:

• compiler_yaml_prompt.go created with package workflow
• compiler_yaml.go drops below 780 lines
• go build ./... and go test ./pkg/workflow/... pass

---

Task 5: Split import_field_extractor.go — extract activation field group

Priority: Low | Effort: Small | Region: pkg/parser/import_field_extractor.go lines 419–529

Description: Move extractActivationFields, extractActivationSkipMatchFields, extractActivationGitHubToken, extractActivationGitHubAppFields, and extractCheckoutField into pkg/parser/import_field_extractor_activation.go. All are *importAccumulator methods; receiver type stays in original file.

Acceptance Criteria:

• import_field_extractor_activation.go created with package parser
• import_field_extractor.go drops below 1200 lines
• go build ./... and go test ./pkg/parser/... pass

---

📊 Historical Context

Previous Focus Areas (last 12 runs)

Date	Focus Area	Type	Custom
2026-05-20	Large File Refactoring & Maintainability	Custom	Y
2026-05-21	Error Message Quality & User Experience	Custom	Y
2026-05-22	MCP Integration Robustness & Error Recovery	Custom	Y
2026-05-25	Test Infrastructure & Build Tag Compliance	Custom	Y
2026-05-26	Go Dependency Hygiene	Custom	Y
2026-05-27	Agentic Workflow Runtime Safety	Custom	Y
2026-05-28	Semantic Constant Adoption	Custom	Y
2026-05-29	CI/CD Pipeline Resilience	Standard	N
2026-06-01	Command Registration Architecture	Custom	Y
2026-06-02	Debug Observability & Test Build Tag	Custom	Y
2026-06-03	Context Propagation & Process Cancellability	Custom	Y
2026-06-04	Linter Registry Completeness	Standard	N

📈 Success Metrics

• Files > 800 lines: 35 → target ≤ 30
• safe_outputs_config.go: 1866 → target ≤ 950
• remote_fetch.go: 1342 → target ≤ 1220
• compiler_yaml.go: 1071 → target ≤ 780

References: run 27018555217

Generated by ⚡ Repository Quality Improvement Agent · 302.1 AIC · ◷

• expires on Jun 6, 2026, 1:56 PM UTC